Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMedia.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutMedia.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutMedia.cpp b/third_party/WebKit/Source/core/layout/LayoutMedia.cpp
index d124303a4a5cdff4858b60a54092d174bda3bb3d..2a0769153cd34847625ace86c1dcebb0c369574a 100644
--- a/third_party/WebKit/Source/core/layout/LayoutMedia.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutMedia.cpp
@@ -64,7 +64,7 @@ void LayoutMedia::layout() {
child = child->previousSibling()) {
#if DCHECK_IS_ON()
if (child->node()->isMediaControls())
- ASSERT(!seenTextTrackContainer);
+ DCHECK(!seenTextTrackContainer);
else if (child->node()->isTextTrackContainer())
seenTextTrackContainer = true;
else
@@ -99,7 +99,7 @@ bool LayoutMedia::isChildAllowed(LayoutObject* child,
const ComputedStyle& style) const {
// Two types of child layout objects are allowed: media controls
// and the text track container. Filter children by node type.
- ASSERT(child->node());
+ DCHECK(child->node());
// Out-of-flow positioned or floating child breaks layout hierarchy.
// This check can be removed if ::-webkit-media-controls is made internal.
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutMedia.h ('k') | third_party/WebKit/Source/core/layout/LayoutMenuList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698