third_party/WebKit/Source/core/layout/LayoutTable.h - Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTable.h

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)

Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTable.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutTable.h b/third_party/WebKit/Source/core/layout/LayoutTable.h

index d5bc8c9284b60e0538c645f1b930a74ad0bf8567..ca71f1e92838c84f837b05c9b06d9d7a8fdb8fa3 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTable.h

+++ b/third_party/WebKit/Source/core/layout/LayoutTable.h

@@ -432,7 +432,7 @@ class CORE_EXPORT LayoutTable final : public LayoutBlock {

void paintMask(const PaintInfo&, const LayoutPoint&) const final;

const CollapsedBorderValues& collapsedBorders() const {

- ASSERT(m_collapsedBordersValid);

+ DCHECK(m_collapsedBordersValid);

return m_collapsedBorders;

}

@@ -606,7 +606,7 @@ class CORE_EXPORT LayoutTable final : public LayoutBlock {

};

inline LayoutTableSection* LayoutTable::topSection() const {

- ASSERT(!needsSectionRecalc());

+ DCHECK(!needsSectionRecalc());

if (m_head)

return m_head;

if (m_firstBody)