Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp b/third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp
index 92adfce70e25b37afcc4d4cfb407086df764094d..d2d3b0835a3d1d583d04568ac6e61bd20e76d03c 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp
@@ -55,8 +55,8 @@ void LayoutObjectChildList::destroyLeftoverChildren() {
LayoutObject* LayoutObjectChildList::removeChildNode(LayoutObject* owner,
LayoutObject* oldChild,
bool notifyLayoutObject) {
- ASSERT(oldChild->parent() == owner);
- ASSERT(this == owner->virtualChildren());
+ DCHECK_EQ(oldChild->parent(), owner);
+ DCHECK_EQ(this, owner->virtualChildren());
if (oldChild->isFloatingOrOutOfFlowPositioned())
toLayoutBox(oldChild)->removeFloatingOrPositionedChildFromBlockLists();
@@ -129,9 +129,9 @@ void LayoutObjectChildList::insertChildNode(LayoutObject* owner,
LayoutObject* newChild,
LayoutObject* beforeChild,
bool notifyLayoutObject) {
- ASSERT(!newChild->parent());
- ASSERT(this == owner->virtualChildren());
- ASSERT(!owner->isLayoutBlockFlow() ||
+ DCHECK(!newChild->parent());
+ DCHECK_EQ(this, owner->virtualChildren());
+ DCHECK(!owner->isLayoutBlockFlow() ||
(!newChild->isTableSection() && !newChild->isTableRow() &&
!newChild->isTableCell()));
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObjectInlines.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698