Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll <knoll@kde.org> 2 * Copyright (C) 1999 Lars Knoll <knoll@kde.org>
3 * Copyright (C) 1999 Antti Koivisto <koivisto@kde.org> 3 * Copyright (C) 1999 Antti Koivisto <koivisto@kde.org>
4 * Copyright (C) 2000 Dirk Mueller <mueller@kde.org> 4 * Copyright (C) 2000 Dirk Mueller <mueller@kde.org>
5 * Copyright (C) 2006 Allan Sandfeld Jensen <kde@carewolf.com> 5 * Copyright (C) 2006 Allan Sandfeld Jensen <kde@carewolf.com>
6 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 6 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010 Apple Inc. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * Copyright (C) 2010 Google Inc. All rights reserved. 9 * Copyright (C) 2010 Google Inc. All rights reserved.
10 * Copyright (C) 2010 Patrick Gansterer <paroga@paroga.com> 10 * Copyright (C) 2010 Patrick Gansterer <paroga@paroga.com>
(...skipping 18 matching lines...) Expand all
29 #include "core/layout/LayoutImageResourceStyleImage.h" 29 #include "core/layout/LayoutImageResourceStyleImage.h"
30 30
31 #include "core/layout/LayoutReplaced.h" 31 #include "core/layout/LayoutReplaced.h"
32 #include "core/style/StyleFetchedImage.h" 32 #include "core/style/StyleFetchedImage.h"
33 33
34 namespace blink { 34 namespace blink {
35 35
36 LayoutImageResourceStyleImage::LayoutImageResourceStyleImage( 36 LayoutImageResourceStyleImage::LayoutImageResourceStyleImage(
37 StyleImage* styleImage) 37 StyleImage* styleImage)
38 : m_styleImage(styleImage) { 38 : m_styleImage(styleImage) {
39 ASSERT(m_styleImage); 39 DCHECK(m_styleImage);
40 } 40 }
41 41
42 LayoutImageResourceStyleImage::~LayoutImageResourceStyleImage() { 42 LayoutImageResourceStyleImage::~LayoutImageResourceStyleImage() {
43 ASSERT(!m_cachedImage); 43 DCHECK(!m_cachedImage);
44 } 44 }
45 45
46 void LayoutImageResourceStyleImage::initialize(LayoutObject* layoutObject) { 46 void LayoutImageResourceStyleImage::initialize(LayoutObject* layoutObject) {
47 LayoutImageResource::initialize(layoutObject); 47 LayoutImageResource::initialize(layoutObject);
48 48
49 if (m_styleImage->isImageResource()) 49 if (m_styleImage->isImageResource())
50 m_cachedImage = toStyleFetchedImage(m_styleImage)->cachedImage(); 50 m_cachedImage = toStyleFetchedImage(m_styleImage)->cachedImage();
51 51
52 m_styleImage->addClient(m_layoutObject); 52 m_styleImage->addClient(m_layoutObject);
53 } 53 }
54 54
55 void LayoutImageResourceStyleImage::shutdown() { 55 void LayoutImageResourceStyleImage::shutdown() {
56 ASSERT(m_layoutObject); 56 DCHECK(m_layoutObject);
57 m_styleImage->removeClient(m_layoutObject); 57 m_styleImage->removeClient(m_layoutObject);
58 m_cachedImage = nullptr; 58 m_cachedImage = nullptr;
59 } 59 }
60 60
61 PassRefPtr<Image> LayoutImageResourceStyleImage::image(const IntSize& size, 61 PassRefPtr<Image> LayoutImageResourceStyleImage::image(const IntSize& size,
62 float zoom) const { 62 float zoom) const {
63 // Generated content may trigger calls to image() while we're still pending, 63 // Generated content may trigger calls to image() while we're still pending,
64 // don't assert but gracefully exit. 64 // don't assert but gracefully exit.
65 if (m_styleImage->isPendingImage()) 65 if (m_styleImage->isPendingImage())
66 return nullptr; 66 return nullptr;
67 return m_styleImage->image(*m_layoutObject, size, zoom); 67 return m_styleImage->image(*m_layoutObject, size, zoom);
68 } 68 }
69 69
70 LayoutSize LayoutImageResourceStyleImage::imageSize(float multiplier) const { 70 LayoutSize LayoutImageResourceStyleImage::imageSize(float multiplier) const {
71 // TODO(davve): Find out the correct default object size in this context. 71 // TODO(davve): Find out the correct default object size in this context.
72 return m_styleImage->imageSize( 72 return m_styleImage->imageSize(
73 *m_layoutObject, multiplier, 73 *m_layoutObject, multiplier,
74 LayoutSize(LayoutReplaced::defaultWidth, LayoutReplaced::defaultHeight)); 74 LayoutSize(LayoutReplaced::defaultWidth, LayoutReplaced::defaultHeight));
75 } 75 }
76 76
77 DEFINE_TRACE(LayoutImageResourceStyleImage) { 77 DEFINE_TRACE(LayoutImageResourceStyleImage) {
78 visitor->trace(m_styleImage); 78 visitor->trace(m_styleImage);
79 LayoutImageResource::trace(visitor); 79 LayoutImageResource::trace(visitor);
80 } 80 }
81 81
82 } // namespace blink 82 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutImageResource.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutInline.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698