Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutView.h

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2006 Apple Computer, Inc. 3 * Copyright (C) 2006 Apple Computer, Inc.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 201
202 void setLayoutQuoteHead(LayoutQuote* head) { m_layoutQuoteHead = head; } 202 void setLayoutQuoteHead(LayoutQuote* head) { m_layoutQuoteHead = head; }
203 LayoutQuote* layoutQuoteHead() const { return m_layoutQuoteHead; } 203 LayoutQuote* layoutQuoteHead() const { return m_layoutQuoteHead; }
204 204
205 // FIXME: This is a work around because the current implementation of counters 205 // FIXME: This is a work around because the current implementation of counters
206 // requires walking the entire tree repeatedly and most pages don't actually 206 // requires walking the entire tree repeatedly and most pages don't actually
207 // use either feature so we shouldn't take the performance hit when not 207 // use either feature so we shouldn't take the performance hit when not
208 // needed. Long term we should rewrite the counter and quotes code. 208 // needed. Long term we should rewrite the counter and quotes code.
209 void addLayoutCounter() { m_layoutCounterCount++; } 209 void addLayoutCounter() { m_layoutCounterCount++; }
210 void removeLayoutCounter() { 210 void removeLayoutCounter() {
211 ASSERT(m_layoutCounterCount > 0); 211 DCHECK_GT(m_layoutCounterCount, 0u);
212 m_layoutCounterCount--; 212 m_layoutCounterCount--;
213 } 213 }
214 bool hasLayoutCounters() { return m_layoutCounterCount; } 214 bool hasLayoutCounters() { return m_layoutCounterCount; }
215 215
216 bool backgroundIsKnownToBeOpaqueInRect( 216 bool backgroundIsKnownToBeOpaqueInRect(
217 const LayoutRect& localRect) const override; 217 const LayoutRect& localRect) const override;
218 218
219 // Returns the viewport size in (CSS pixels) that vh and vw units are 219 // Returns the viewport size in (CSS pixels) that vh and vw units are
220 // calculated from. 220 // calculated from.
221 FloatSize viewportSizeForViewportUnits() const; 221 FloatSize viewportSizeForViewportUnits() const;
222 222
223 void pushLayoutState(LayoutState& layoutState) { 223 void pushLayoutState(LayoutState& layoutState) {
224 m_layoutState = &layoutState; 224 m_layoutState = &layoutState;
225 } 225 }
226 void popLayoutState() { 226 void popLayoutState() {
227 ASSERT(m_layoutState); 227 DCHECK(m_layoutState);
228 m_layoutState = m_layoutState->next(); 228 m_layoutState = m_layoutState->next();
229 } 229 }
230 230
231 LayoutRect visualOverflowRect() const override; 231 LayoutRect visualOverflowRect() const override;
232 LayoutRect localVisualRect() const override; 232 LayoutRect localVisualRect() const override;
233 233
234 // Invalidates paint for the entire view, including composited descendants, 234 // Invalidates paint for the entire view, including composited descendants,
235 // but not including child frames. 235 // but not including child frames.
236 // It is very likely you do not want to call this method. 236 // It is very likely you do not want to call this method.
237 void setShouldDoFullPaintInvalidationForViewAndAllDescendants(); 237 void setShouldDoFullPaintInvalidationForViewAndAllDescendants();
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 unsigned m_hitTestCount; 327 unsigned m_hitTestCount;
328 unsigned m_hitTestCacheHits; 328 unsigned m_hitTestCacheHits;
329 Persistent<HitTestCache> m_hitTestCache; 329 Persistent<HitTestCache> m_hitTestCache;
330 }; 330 };
331 331
332 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutView, isLayoutView()); 332 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutView, isLayoutView());
333 333
334 } // namespace blink 334 } // namespace blink
335 335
336 #endif // LayoutView_h 336 #endif // LayoutView_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698