third_party/WebKit/Source/core/layout/LayoutTableRow.cpp - Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)

Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp b/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

index 3184ad5c5a4ef04f7f70463640b98b687cc92e81..decf5b332670c787379b72355f9eef2010926c75 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

@@ -162,7 +162,7 @@ void LayoutTableRow::addChild(LayoutObject* child, LayoutObject* beforeChild) {

LayoutTableCell* cell = toLayoutTableCell(child);

- ASSERT(!beforeChild || beforeChild->isTableCell());

+ DCHECK(!beforeChild || beforeChild->isTableCell());

LayoutTableBoxComponent::addChild(cell, beforeChild);

// Generated content can result in us having a null section so make sure to

@@ -187,7 +187,7 @@ void LayoutTableRow::addChild(LayoutObject* child, LayoutObject* beforeChild) {

}

void LayoutTableRow::layout() {

- ASSERT(needsLayout());

+ DCHECK(needsLayout());

LayoutAnalyzer::Scope analyzer(*this);

bool paginated = view()->layoutState()->isPaginated();