Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutFrameSet.h

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Simon Hausmann <hausmann@kde.org> 3 * (C) 2000 Simon Hausmann <hausmann@kde.org>
4 * Copyright (C) 2006, 2008 Apple Inc. All rights reserved. 4 * Copyright (C) 2006, 2008 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 Vector<bool> m_preventResize; 55 Vector<bool> m_preventResize;
56 Vector<bool> m_allowBorder; 56 Vector<bool> m_allowBorder;
57 }; 57 };
58 58
59 class LayoutFrameSet final : public LayoutBox { 59 class LayoutFrameSet final : public LayoutBox {
60 public: 60 public:
61 LayoutFrameSet(HTMLFrameSetElement*); 61 LayoutFrameSet(HTMLFrameSetElement*);
62 ~LayoutFrameSet() override; 62 ~LayoutFrameSet() override;
63 63
64 LayoutObject* firstChild() const { 64 LayoutObject* firstChild() const {
65 ASSERT(children() == virtualChildren()); 65 DCHECK_EQ(children(), virtualChildren());
66 return children()->firstChild(); 66 return children()->firstChild();
67 } 67 }
68 LayoutObject* lastChild() const { 68 LayoutObject* lastChild() const {
69 ASSERT(children() == virtualChildren()); 69 DCHECK_EQ(children(), virtualChildren());
70 return children()->lastChild(); 70 return children()->lastChild();
71 } 71 }
72 72
73 // If you have a LayoutFrameSet, use firstChild or lastChild instead. 73 // If you have a LayoutFrameSet, use firstChild or lastChild instead.
74 void slowFirstChild() const = delete; 74 void slowFirstChild() const = delete;
75 void slowLastChild() const = delete; 75 void slowLastChild() const = delete;
76 76
77 const LayoutObjectChildList* children() const { return &m_children; } 77 const LayoutObjectChildList* children() const { return &m_children; }
78 LayoutObjectChildList* children() { return &m_children; } 78 LayoutObjectChildList* children() { return &m_children; }
79 79
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 150
151 bool m_isResizing; 151 bool m_isResizing;
152 bool m_isChildResizing; 152 bool m_isChildResizing;
153 }; 153 };
154 154
155 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutFrameSet, isFrameSet()); 155 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutFrameSet, isFrameSet());
156 156
157 } // namespace blink 157 } // namespace blink
158 158
159 #endif // LayoutFrameSet_h 159 #endif // LayoutFrameSet_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698