Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp
diff --git a/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp b/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp
index 0c4c42d5cf5195a8fe428e3262db46ad56be027d..70d92881d635ef658a25fbe242bc345ec31db909 100644
--- a/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp
+++ b/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp
@@ -500,8 +500,8 @@ int TableLayoutAlgorithmAuto::calcEffectiveLogicalWidth() {
allocatedMinLogicalWidth += columnMinLogicalWidth;
allocatedMaxLogicalWidth += columnMaxLogicalWidth;
}
- ASSERT(allocatedMinLogicalWidth <= cellMinLogicalWidth);
- ASSERT(allocatedMaxLogicalWidth <= cellMaxLogicalWidth);
+ DCHECK_LE(allocatedMinLogicalWidth, cellMinLogicalWidth);
+ DCHECK_LE(allocatedMaxLogicalWidth, cellMaxLogicalWidth);
cellMinLogicalWidth -= allocatedMinLogicalWidth;
cellMaxLogicalWidth -= allocatedMaxLogicalWidth;
} else {
@@ -768,7 +768,7 @@ void TableLayoutAlgorithmAuto::layout() {
if (available < 0)
shrinkColumnWidth(Percent, available);
- ASSERT(m_table->effectiveColumnPositions().size() == nEffCols + 1);
+ DCHECK_EQ(m_table->effectiveColumnPositions().size(), nEffCols + 1);
int pos = 0;
for (size_t i = 0; i < nEffCols; ++i) {
m_table->setEffectiveColumnPosition(i, pos);

Powered by Google App Engine
This is Rietveld 408576698