Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableCell.h

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableCell.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableCell.h b/third_party/WebKit/Source/core/layout/LayoutTableCell.h
index e1d9e970e49c2a94e7acba2a0c5f789209a7d60f..59343c4e87a6a4451d81bcee9914f60538ec3095 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableCell.h
+++ b/third_party/WebKit/Source/core/layout/LayoutTableCell.h
@@ -114,7 +114,7 @@ class CORE_EXPORT LayoutTableCell final : public LayoutBlockFlow {
}
unsigned absoluteColumnIndex() const {
- ASSERT(hasSetAbsoluteColumnIndex());
+ DCHECK(hasSetAbsoluteColumnIndex());
return m_absoluteColumnIndex;
}
@@ -131,7 +131,7 @@ class CORE_EXPORT LayoutTableCell final : public LayoutBlockFlow {
unsigned rowIndex() const {
// This function shouldn't be called on a detached cell.
- ASSERT(row());
+ DCHECK(row());
return row()->rowIndex();
}
@@ -251,7 +251,9 @@ class CORE_EXPORT LayoutTableCell final : public LayoutBlockFlow {
const ComputedStyle& styleForCellFlow() const { return row()->styleRef(); }
const BorderValue& borderAdjoiningTableStart() const {
- ASSERT(isFirstOrLastCellInRow());
+#if DCHECK_IS_ON()
+ DCHECK(isFirstOrLastCellInRow());
+#endif
if (section()->hasSameDirectionAs(table()))
return style()->borderStart();
@@ -259,7 +261,9 @@ class CORE_EXPORT LayoutTableCell final : public LayoutBlockFlow {
}
const BorderValue& borderAdjoiningTableEnd() const {
- ASSERT(isFirstOrLastCellInRow());
+#if DCHECK_IS_ON()
+ DCHECK(isFirstOrLastCellInRow());
+#endif
if (section()->hasSameDirectionAs(table()))
return style()->borderEnd();
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTable.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTableCell.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698