third_party/WebKit/Source/core/layout/LayoutThemeMac.mm - Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)

Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

diff --git a/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm b/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

index a0dec32d91586f2c92afacbb5c50d3b30f8354da..30003cb058a561b852613b5dfef0f93800449525 100644

--- a/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

+++ b/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

@@ -199,7 +199,8 @@ Color LayoutThemeMac::platformInactiveListBoxSelectionBackgroundColor() const {

}

static FontWeight toFontWeight(NSInteger appKitFontWeight) {

- ASSERT(appKitFontWeight > 0 && appKitFontWeight < 15);

+ DCHECK_GT(appKitFontWeight, 0);

+ DCHECK_LT(appKitFontWeight, 15);

if (appKitFontWeight > 14)

appKitFontWeight = 14;

else if (appKitFontWeight < 1)