Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutQuote.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutQuote.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutQuote.cpp b/third_party/WebKit/Source/core/layout/LayoutQuote.cpp
index 3db4be4eb263272f60e2115555e4d56f02dc848b..c510589e8581776dcef34ed546bf8c153535957f 100644
--- a/third_party/WebKit/Source/core/layout/LayoutQuote.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutQuote.cpp
@@ -43,8 +43,9 @@ LayoutQuote::LayoutQuote(PseudoElement& pseudo, QuoteType quote)
}
LayoutQuote::~LayoutQuote() {
- ASSERT(!m_attached);
- ASSERT(!m_next && !m_previous);
+ DCHECK(!m_attached);
+ DCHECK(!m_next);
+ DCHECK(!m_previous);
}
void LayoutQuote::willBeDestroyed() {
@@ -309,10 +310,11 @@ const QuotesData* LayoutQuote::quotesData() const {
}
void LayoutQuote::attachQuote() {
- ASSERT(view());
- ASSERT(!m_attached);
- ASSERT(!m_next && !m_previous);
- ASSERT(isRooted());
+ DCHECK(view());
+ DCHECK(!m_attached);
+ DCHECK(!m_next);
+ DCHECK(!m_previous);
+ DCHECK(isRooted());
if (!view()->layoutQuoteHead()) {
view()->setLayoutQuoteHead(this);
@@ -345,15 +347,15 @@ void LayoutQuote::attachQuote() {
for (LayoutQuote* quote = this; quote; quote = quote->m_next)
quote->updateDepth();
- ASSERT(!m_next || m_next->m_attached);
- ASSERT(!m_next || m_next->m_previous == this);
- ASSERT(!m_previous || m_previous->m_attached);
- ASSERT(!m_previous || m_previous->m_next == this);
+ DCHECK(!m_next || m_next->m_attached);
+ DCHECK(!m_next || m_next->m_previous == this);
+ DCHECK(!m_previous || m_previous->m_attached);
+ DCHECK(!m_previous || m_previous->m_next == this);
}
void LayoutQuote::detachQuote() {
- ASSERT(!m_next || m_next->m_attached);
- ASSERT(!m_previous || m_previous->m_attached);
+ DCHECK(!m_next || m_next->m_attached);
+ DCHECK(!m_previous || m_previous->m_attached);
if (!m_attached)
return;
@@ -378,7 +380,7 @@ void LayoutQuote::detachQuote() {
}
void LayoutQuote::updateDepth() {
- ASSERT(m_attached);
+ DCHECK(m_attached);
int oldDepth = m_depth;
m_depth = 0;
if (m_previous) {
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutPart.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutReplaced.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698