third_party/WebKit/Source/core/layout/LayoutFrameSet.h - Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFrameSet.h

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)

Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutFrameSet.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutFrameSet.h b/third_party/WebKit/Source/core/layout/LayoutFrameSet.h

index 5751f4ce0393b7dfde8b6cc58dcecd04755681fb..869a37dd789d663d901faf60cb0c205bef80e035 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFrameSet.h

+++ b/third_party/WebKit/Source/core/layout/LayoutFrameSet.h

@@ -62,11 +62,11 @@ class LayoutFrameSet final : public LayoutBox {

~LayoutFrameSet() override;

LayoutObject* firstChild() const {

- ASSERT(children() == virtualChildren());

+ DCHECK_EQ(children(), virtualChildren());

return children()->firstChild();

}

LayoutObject* lastChild() const {

- ASSERT(children() == virtualChildren());

+ DCHECK_EQ(children(), virtualChildren());

return children()->lastChild();

}