Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutPart.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutPart.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutPart.cpp b/third_party/WebKit/Source/core/layout/LayoutPart.cpp
index 9078c43ead331db2c248178d7033e6bdbb811f39..6dabc0fce6b725d69b0541961c50fcc2c31ca95e 100644
--- a/third_party/WebKit/Source/core/layout/LayoutPart.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutPart.cpp
@@ -44,7 +44,7 @@ LayoutPart::LayoutPart(Element* element)
// while inside the FrameViewBase code, which might not be able to handle
// that.
m_refCount(1) {
- ASSERT(element);
+ DCHECK(element);
frameView()->addPart(this);
setInline(false);
}
@@ -85,7 +85,7 @@ void LayoutPart::destroy() {
}
LayoutPart::~LayoutPart() {
- ASSERT(m_refCount <= 0);
+ DCHECK_LE(m_refCount, 0);
}
FrameViewBase* LayoutPart::frameViewBase() const {
@@ -172,7 +172,8 @@ bool LayoutPart::nodeAtPoint(HitTestResult& result,
accumulatedOffset, action);
}
- ASSERT(document().lifecycle().state() >= DocumentLifecycle::CompositingClean);
+ DCHECK_GE(document().lifecycle().state(),
+ DocumentLifecycle::CompositingClean);
if (action == HitTestForeground) {
FrameView* childFrameView = toFrameView(frameViewBase());
@@ -255,7 +256,7 @@ void LayoutPart::styleDidChange(StyleDifference diff,
}
void LayoutPart::layout() {
- ASSERT(needsLayout());
+ DCHECK(needsLayout());
LayoutAnalyzer::Scope analyzer(*this);
clearNeedsLayout();
}
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutPagedFlowThread.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutQuote.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698