third_party/WebKit/Source/core/layout/LayoutAnalyzer.cpp - Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutAnalyzer.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)

Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutAnalyzer.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutAnalyzer.cpp b/third_party/WebKit/Source/core/layout/LayoutAnalyzer.cpp

index 19f779f557bc8a9fac8a326a09bc86ff85f19d4e..79ab09e181248e90a2cc0b01d9214c00c6aadce9 100644

--- a/third_party/WebKit/Source/core/layout/LayoutAnalyzer.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutAnalyzer.cpp

@@ -91,7 +91,7 @@ void LayoutAnalyzer::push(const LayoutObject& o) {

}

void LayoutAnalyzer::pop(const LayoutObject& o) {

- ASSERT(m_depth > 0);

+ DCHECK_GT(m_depth, 0u);

--m_depth;

}