Issue 2059283002: Fix SkImage::asLegacyBitmap() to respect color space info

Issue 2059283002: Fix SkImage::asLegacyBitmap() to respect color space info (Closed)

Created:
4 years, 6 months ago by msarett

Modified:
4 years, 4 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix SkImage::asLegacyBitmap() to respect color space info All kinds of stuff BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2059283002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Patch Set 1 #

Patch Set 2 : Load and math in parallel in SkColorXform_opts #

Patch Set 3 : Fix compile error on MSAN bot #

Patch Set 4 : Fix yasm for Android build #

Patch Set 5 : Keep define #

Patch Set 6 : Fix Equals and serialization for rare pngs #

Patch Set 7 : Fix initialization bug for fConservativeIsScaleTranslate, also it's no longer conservative #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	include/core/SkCanvas.h	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/core/SkCanvas.cpp	View	1 2 3 4 5 6	7 chunks	+8 lines, -8 lines	0 comments	Download

Dependent Patchsets:

Issue 2261573002 Patch 1

Issue 2255963002 Patch 200001

Issue 2263513003 Patch 20001

Issue 2263513003 Patch 40001

Issue 2257983003 Patch 1

Issue 2221983002 Patch 20001

Issue 2221983002 Patch 40001

Issue 2261213002 Patch 1

Issue 2263233003 Patch 40001

Issue 2261173004 Patch 1

Issue 2263233003 Patch 60001

Issue 2275563002 Patch 1

Issue 2277463002 Patch 1

Issue 2277463002 Patch 20001

Issue 2277463002 Patch 70001

Issue 2269333002 Patch 1

Issue 2269333002 Patch 20001

Issue 2275563002 Patch 20001

Issue 2274843002 Patch 1

Issue 2269333002 Patch 40001

Issue 2269333002 Patch 60001

Issue 2277053002 Patch 1

Issue 2277053002 Patch 10001

Issue 2277053002 Patch 50001

Issue 2277053002 Patch 70001

Issue 2286693002 Patch 1

Issue 2279313003 Patch 1

Issue 2282983003 Patch 40001

Issue 2290683002 Patch 1

Issue 2290843002 Patch 1

Issue 2293633003 Patch 1

Issue 2290843002 Patch 20001

Issue 2293633003 Patch 40001

Issue 2288163003 Patch 20001

Issue 2297833003 Patch 1

Issue 2279313003 Patch 20001

Issue 2305433002 Patch 1

Issue 2305433002 Patch 10012

Issue 2305433002 Patch 30001

Issue 2305433002 Patch 50001

Issue 2302953002 Patch 20001

Issue 2305433002 Patch 70001

Issue 2304753002 Patch 1

Issue 2304753002 Patch 20001

Issue 2279313003 Patch 40001

Issue 2306123002 Patch 1

Issue 2305433002 Patch 110001

Issue 2302413002 Patch 20001

Issue 2302413002 Patch 60001

Issue 2302413002 Patch 80001

Issue 2311793004 Patch 1

Issue 2311793004 Patch 20001

Issue 2319073002 Patch 1

Issue 2322543002 Patch 1

Issue 2318663003 Patch 140001

Issue 2311793004 Patch 40001

Issue 2311793004 Patch 60001

Issue 2304753002 Patch 140001

Issue 2294993002 Patch 60001

Issue 2319293002 Patch 1

Issue 2294993002 Patch 80001

Issue 2319293002 Patch 20001

Issue 2294993002 Patch 100001

Issue 2326603002 Patch 1

Issue 2319293003 Patch 120001

Issue 2325793002 Patch 1

Issue 2326043002 Patch 20001

Issue 2326043002 Patch 40001

Issue 2325223002 Patch 1

Issue 2325223002 Patch 20001

Issue 2325223002 Patch 40001

Issue 2325223002 Patch 120001

Issue 2325223002 Patch 160001

Issue 2325223002 Patch 180001

Issue 2335723002 Patch 40001

Issue 2335723002 Patch 60001

Issue 2335203002 Patch 20001

Issue 2335203002 Patch 40001

Issue 2335203002 Patch 60001

Issue 2335203002 Patch 80001

Issue 2335723002 Patch 100001

Issue 2335723002 Patch 120001

Issue 2344523002 Patch 1

Issue 2336913005 Patch 1

Issue 2336913005 Patch 20001

Issue 2338203005 Patch 1

Issue 2339793003 Patch 1

Issue 2339233003 Patch 1

Issue 2339233003 Patch 40001

Issue 2339233003 Patch 60001

Issue 2339233003 Patch 80001

Issue 2339233003 Patch 100001

Issue 2340913002 Patch 1

Issue 2344523002 Patch 20001

Issue 2341143002 Patch 1

Issue 2339233003 Patch 120001

Issue 2339233003 Patch 140001

Issue 2344523002 Patch 40001

Issue 2339233003 Patch 160001

Issue 2343153003 Patch 1

Issue 2351083002 Patch 1

Issue 2355703003 Patch 1

Issue 2352083004 Patch 20001

Issue 2357273003 Patch 1

Issue 2358873003 Patch 1

Issue 2360863003 Patch 1

Issue 2362863002 Patch 1

Issue 2381553002 Patch 1

Issue 2381553002 Patch 20001

Issue 2381553002 Patch 40001

Issue 2381553002 Patch 60001

Issue 2382893002 Patch 1

Issue 2382893002 Patch 20001

Issue 2382893002 Patch 40001

Issue 2382893002 Patch 60001

Issue 2383223003 Patch 1

Issue 2304753002 Patch 240001

Issue 2390263002 Patch 1

Issue 2390263002 Patch 40001

Issue 2390263002 Patch 60001

Issue 2391933004 Patch 1

Issue 2390263002 Patch 80001

Issue 2390263002 Patch 120001

Issue 2304753002 Patch 260001

Issue 2304753002 Patch 280001

Issue 2304753002 Patch 320001

Issue 2304753002 Patch 340001

Issue 2390263002 Patch 140001

Issue 2409383002 Patch 1

Issue 2409383002 Patch 20001

Issue 2418643002 Patch 1

Issue 2418643002 Patch 20001

Issue 2413383002 Patch 1

Issue 2408133009 Patch 1

Issue 2257983003 Patch 20001

Issue 2433323005 Patch 1

Messages

Total messages: 2 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

msarett

Description was changed from ========== Fix SkImage::asLegacyBitmap() to respect color space info All kinds of ...

4 years, 6 months ago (2016-06-13 16:38:53 UTC) #1

msarett

4 years, 6 months ago (2016-06-13 16:42:24 UTC) #2

Description was changed from

==========
Fix SkImage::asLegacyBitmap() to respect color space info


All kinds of stuff

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2059283002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Fix SkImage::asLegacyBitmap() to respect color space info


All kinds of stuff

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2059283002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages