Add Gray support to SkPNGImageEncoder

Add Gray support to SkPNGImageEncoder

BUG=skia:5616
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2290843002

Committed: https://skia.googlesource.com/skia/+/9b09cd8372ad0b25da20a50d9967bb02f9f2f9d8

[msarett, 2016-08-29 20:34:19]

Description was changed from

==========
Add Gray support to SkPNGImageEncoder

BUG=skia:5616
==========

to

==========
Add Gray support to SkPNGImageEncoder

BUG=skia:5616
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2290843002
==========

[msarett, 2016-08-29 21:02:12]

msarett@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[reed1, 2016-08-29 21:04:12]

lgtm

[mtklein, 2016-08-29 21:06:41]

lgtm

[mtklein, 2016-08-29 21:08:08]

https://codereview.chromium.org/2290843002/diff/1/src/images/SkPNGImageEncode...
File src/images/SkPNGImageEncoder.cpp (right):

https://codereview.chromium.org/2290843002/diff/1/src/images/SkPNGImageEncode...
src/images/SkPNGImageEncoder.cpp:199: memset(&sig_bit, 0, sizeof(png_color_8));
good idea generally to use sk_bzero() for this sort of thing, to avoid
accidentally writing memset(dst, count, 0)

[msarett, 2016-08-29 21:13:27]

https://codereview.chromium.org/2290843002/diff/1/src/images/SkPNGImageEncode...
File src/images/SkPNGImageEncoder.cpp (right):

https://codereview.chromium.org/2290843002/diff/1/src/images/SkPNGImageEncode...
src/images/SkPNGImageEncoder.cpp:199: memset(&sig_bit, 0, sizeof(png_color_8));
On 2016/08/29 21:08:08, mtklein wrote:
> good idea generally to use sk_bzero() for this sort of thing, to avoid
> accidentally writing memset(dst, count, 0)

Done.

[msarett, 2016-08-29 21:13:54]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 21:13:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 21:43:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 21:43:13]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-08-29 21:45:54]

The CQ bit was checked by msarett@google.com

[msarett, 2016-08-29 21:45:55]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/2290843002/#ps20001
(title: "use sk_bzero()")

[commit-bot: I haz the power, 2016-08-29 21:46:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 21:47:52]

Description was changed from

==========
Add Gray support to SkPNGImageEncoder

BUG=skia:5616
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2290843002
==========

to

==========
Add Gray support to SkPNGImageEncoder

BUG=skia:5616
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2290843002

Committed:
https://skia.googlesource.com/skia/+/9b09cd8372ad0b25da20a50d9967bb02f9f2f9d8
==========

[commit-bot: I haz the power, 2016-08-29 21:47:53]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9b09cd8372ad0b25da20a50d9967bb02f9f2f9d8