Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2286693002: drawRegion() cleanups (Closed)

Created:
4 years, 3 months ago by msarett
Modified:
4 years, 3 months ago
Reviewers:
bsalomon, djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

drawRegion() cleanups (1) Move implementation to the cpp. (2) Check for the isRect() case. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2286693002 Committed: https://skia.googlesource.com/skia/+/dca352e2d42cfe698573947b3d11abc1eaade160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M include/core/SkCanvas.h View 1 chunk +1 line, -7 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +12 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
msarett
Responding to a few comments from: https://codereview.chromium.org/2277053002/
4 years, 3 months ago (2016-08-26 13:05:16 UTC) #3
bsalomon
lgtm
4 years, 3 months ago (2016-08-26 13:07:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286693002/1
4 years, 3 months ago (2016-08-26 13:36:51 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 13:37:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dca352e2d42cfe698573947b3d11abc1eaade160

Powered by Google App Engine
This is Rietveld 408576698