Issue 2408133009: Add NewRGB() with float gamma to SkColorSpace public API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2408133009: Add NewRGB() with float gamma to SkColorSpace public API

Created:
4 years, 2 months ago by msarett

Modified:
4 years, 2 months ago

Reviewers:

CC:
reviews_skia.org

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Add NewRGB() with float gamma to SkColorSpace public API Necessary because PNGs like ro specify their gamma this way. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2408133009

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -14 lines)			Patch
M	include/core/SkColorSpace.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/codec/SkPngCodec.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/core/SkColorSpace.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/core/SkColorSpace_Base.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/ColorSpaceTest.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/SurfaceTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 2059283002 Patch 120001

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

msarett

4 years, 2 months ago (2016-10-13 22:23:09 UTC) #1

Description was changed from

==========
Add NewRGB() with float gamma to SkColorSpace public API

Necessary because PNGs like ro specify their gamma this way.

BUG=skia:
==========

to

==========
Add NewRGB() with float gamma to SkColorSpace public API

Necessary because PNGs like ro specify their gamma this way.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2408133009
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages