Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2305433002: Add option to skip rects to drawImageLattice() (Closed)

Created:
4 years, 3 months ago by msarett
Modified:
4 years, 3 months ago
Reviewers:
mtklein, djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add option to skip rects to drawImageLattice() HWUI skips transparent rects when drawing. When skia draws using bilerp, we will blend transparent rects with neighboring rects and might draw a bit of a smudge. This CL adds the option to skip rects, allowing us to have compatible behavior with the framework. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2305433002 Committed: https://skia.googlesource.com/skia/+/0764efe6a9ae65ad83992f614f57ca9db5b1f191

Patch Set 1 #

Patch Set 2 : Fix fNumRects to be accurate #

Patch Set 3 : numRectsToDraw() #

Total comments: 2

Patch Set 4 : Do not store fFlagCount in lattice struct #

Total comments: 1

Patch Set 5 : Simpler #

Patch Set 6 : Better detection for zero divs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -55 lines) Patch
M bench/DrawLatticeBench.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gm/lattice.cpp View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M include/core/SkCanvas.h View 1 2 3 1 chunk +22 lines, -8 lines 0 comments Download
M include/private/SkRecords.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkLatticeIter.h View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M src/core/SkLatticeIter.cpp View 1 2 3 4 5 8 chunks +60 lines, -28 lines 0 comments Download
M src/core/SkLiteDL.cpp View 1 2 3 3 chunks +16 lines, -10 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M src/core/SkRecordDraw.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkRecorder.cpp View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/batches/GrNinePatch.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 30 (23 generated)
msarett
4 years, 3 months ago (2016-08-31 22:40:44 UTC) #5
mtklein
All the recordy stuff lgtm
4 years, 3 months ago (2016-09-01 13:20:50 UTC) #9
reed1
packing nit: int* int* char* int int packs a little nicer on 64bit machines than ...
4 years, 3 months ago (2016-09-01 14:15:24 UTC) #10
msarett
Removed fFlagCount from the Lattice struct. This requires a little extra thinking in SkLatticeIter and ...
4 years, 3 months ago (2016-09-01 16:27:24 UTC) #11
reed1
lgtm
4 years, 3 months ago (2016-09-01 17:25:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305433002/110001
4 years, 3 months ago (2016-09-02 17:27:41 UTC) #28
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 18:24:43 UTC) #30
Message was sent while issue was closed.
Committed patchset #6 (id:110001) as
https://skia.googlesource.com/skia/+/0764efe6a9ae65ad83992f614f57ca9db5b1f191

Powered by Google App Engine
This is Rietveld 408576698