Add a src rect to drawImageLattice() API

Add a src rect to drawImageLattice() API

This will allow us to draw ninepatches directly from an asset
texture without having to upload them individually.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2382893002

Committed: https://skia.googlesource.com/skia/+/71df2d7bc1bbc83ad4cf005f9027df4cb3b88a9b

[msarett, 2016-09-29 20:43:18]

Description was changed from

==========
Add a src rect to drawImageLattice() API

This will allow us to draw ninepatches directly from an asset
texture without having to upload them individually.

BUG=skia:
==========

to

==========
Add a src rect to drawImageLattice() API

This will allow us to draw ninepatches directly from an asset
texture without having to upload them individually.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2382893002
==========

[msarett, 2016-09-29 20:45:55]

msarett@google.com changed reviewers:
+ djsollen@google.com, mtklein@google.com, reed@google.com

[msarett, 2016-09-29 20:45:56]

Change is actually not that complex - just a lot of recording canvases to
update.

[msarett, 2016-09-29 20:46:00]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 20:46:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 20:53:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 20:53:14]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[msarett, 2016-09-29 20:56:01]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 20:56:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-09-29 21:11:38]

https://codereview.chromium.org/2382893002/diff/20001/include/core/SkCanvas.h
File include/core/SkCanvas.h (right):

https://codereview.chromium.org/2382893002/diff/20001/include/core/SkCanvas.h...
include/core/SkCanvas.h:992: // input SkImage.
1. could take a ptr to a rect, and null means the entire src (just a thought,
matches some of our other calls)
2. what is our behavior defined to be if fBounds extends beyond the image
dimensions? is empty or inverted?

[msarett, 2016-09-29 21:18:59]

On 2016/09/29 21:11:38, reed1 wrote:
> https://codereview.chromium.org/2382893002/diff/20001/include/core/SkCanvas.h
> File include/core/SkCanvas.h (right):
> 
>
https://codereview.chromium.org/2382893002/diff/20001/include/core/SkCanvas.h...
> include/core/SkCanvas.h:992: // input SkImage.
> 1. could take a ptr to a rect, and null means the entire src (just a thought,
> matches some of our other calls)

sgtm, will give this a shot in PS2

> 2. what is our behavior defined to be if fBounds extends beyond the image
> dimensions? is empty or inverted?

SkLatticeIter::Valid() will return false - in this case we just ignore the
lattice and draw into dst.  Arguably, we should just draw nothing...  I don't
feel strongly, but this should probably be a separate change.

[commit-bot: I haz the power, 2016-09-29 21:21:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 21:21:17]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-09-29 22:36:47]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 22:36:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msarett, 2016-09-29 22:37:13]

PS 2 improves the comments and makes the bounds rect optional.

[commit-bot: I haz the power, 2016-09-29 23:02:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 23:02:57]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-09-30 18:25:57]

lgtm

[msarett, 2016-09-30 19:03:39]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 19:03:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 19:36:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 19:36:27]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-09-30 19:40:17]

The CQ bit was checked by msarett@google.com

[msarett, 2016-09-30 19:40:17]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/2382893002/#ps60001
(title: "Simplify impl")

[commit-bot: I haz the power, 2016-09-30 19:40:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-09-30 19:41:38]

lgtm

[commit-bot: I haz the power, 2016-09-30 19:41:44]

Description was changed from

==========
Add a src rect to drawImageLattice() API

This will allow us to draw ninepatches directly from an asset
texture without having to upload them individually.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2382893002
==========

to

==========
Add a src rect to drawImageLattice() API

This will allow us to draw ninepatches directly from an asset
texture without having to upload them individually.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2382893002

Committed:
https://skia.googlesource.com/skia/+/71df2d7bc1bbc83ad4cf005f9027df4cb3b88a9b
==========

[commit-bot: I haz the power, 2016-09-30 19:41:45]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/71df2d7bc1bbc83ad4cf005f9027df4cb3b88a9b