Make singleton SkColorSpaces thread safe

Make singleton SkColorSpaces thread safe

SkColorSpaces may be once-ptrs, so we can reuse common color spaces.
This means that they must be thread safe.  SkMatrix44 is not
thread safe because it maintains a mutable type mask.

This CL ensures that we precompute the type mask so we
can use const SkMatrix44's safely.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277463002

Committed: https://skia.googlesource.com/skia/+/ae6377c08e5c3735c65212ba9ff86fa51af7d68a

[msarett, 2016-08-23 20:02:32]

Description was changed from

==========
Limit TSAN failures

SkColorSpaces may be once-ptrs, so we can reuse common color spaces.
This means that they must be thread safe.  SkMatrix44 is not
thread safe.

This won't fix the above problem, but it might make TSAN less
likely to fail.

BUG=skia:
==========

to

==========
Limit TSAN failures

SkColorSpaces may be once-ptrs, so we can reuse common color spaces.
This means that they must be thread safe.  SkMatrix44 is not
thread safe.

This won't fix the above problem, but it might make TSAN less
likely to fail.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277463002
==========

[msarett, 2016-08-23 20:03:06]

msarett@google.com changed reviewers:
+ bungeman@google.com

[msarett, 2016-08-23 20:29:40]

Description was changed from

==========
Limit TSAN failures

SkColorSpaces may be once-ptrs, so we can reuse common color spaces.
This means that they must be thread safe.  SkMatrix44 is not
thread safe.

This won't fix the above problem, but it might make TSAN less
likely to fail.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277463002
==========

to

==========
Make singleton SkColorSpaces thread safe

SkColorSpaces may be once-ptrs, so we can reuse common color spaces.
This means that they must be thread safe.  SkMatrix44 is not
thread safe because it maintains a mutable type mask.

This CL ensures that we precompute the type mask so we
can use const SkMatrix44's safely.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277463002
==========

[msarett, 2016-08-23 20:30:18]

msarett@google.com changed reviewers:
+ mtklein@google.com

[msarett, 2016-08-23 20:30:18]

PTAL, now this actually fixes the problem.

[bungeman-skia, 2016-08-23 20:53:19]

bungeman@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com

[bungeman-skia, 2016-08-23 20:53:19]

The gist of this lgtm, but I'll let the API owners bikeshed the name.

[mtklein, 2016-08-23 20:55:03]

FWIW, the way I do this on 3x3 SkMatrix is 
(void)matrix->getType();

[msarett, 2016-08-23 21:03:36]

Patchset #3 (id:40001) has been deleted

[msarett, 2016-08-23 21:04:03]

Thoughts on Patch Set 3?

[bsalomon, 2016-08-23 21:07:22]

On 2016/08/23 21:04:03, msarett wrote:
> Thoughts on Patch Set 3?

lgtm

[msarett, 2016-08-23 21:07:26]

Patchset #3 (id:60001) has been deleted

[msarett, 2016-08-23 21:10:43]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 21:10:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 21:35:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 21:35:06]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-08-23 21:35:22]

The CQ bit was checked by msarett@google.com

[msarett, 2016-08-23 21:35:23]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com
Link to the patchset: https://codereview.chromium.org/2277463002/#ps70001
(title: "Use getType() to force compute of type mask")

[commit-bot: I haz the power, 2016-08-23 21:35:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 21:36:22]

Description was changed from

==========
Make singleton SkColorSpaces thread safe

SkColorSpaces may be once-ptrs, so we can reuse common color spaces.
This means that they must be thread safe.  SkMatrix44 is not
thread safe because it maintains a mutable type mask.

This CL ensures that we precompute the type mask so we
can use const SkMatrix44's safely.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277463002
==========

to

==========
Make singleton SkColorSpaces thread safe

SkColorSpaces may be once-ptrs, so we can reuse common color spaces.
This means that they must be thread safe.  SkMatrix44 is not
thread safe because it maintains a mutable type mask.

This CL ensures that we precompute the type mask so we
can use const SkMatrix44's safely.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277463002

Committed:
https://skia.googlesource.com/skia/+/ae6377c08e5c3735c65212ba9ff86fa51af7d68a
==========

[commit-bot: I haz the power, 2016-08-23 21:36:23]

Committed patchset #3 (id:70001) as
https://skia.googlesource.com/skia/+/ae6377c08e5c3735c65212ba9ff86fa51af7d68a