Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2288163003: Add Alpha8 support to SkPNGImageEncoder

Created:
4 years, 3 months ago by msarett
Modified:
4 years, 3 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add Alpha8 support to SkPNGImageEncoder This is done by including a custom key/value in the text chunk. I've updated our decoder to understand this message. BUG=skia:5616 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288163003

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -5 lines) Patch
M src/codec/SkAndroidCodec.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M src/codec/SkPngCodec.cpp View 1 chunk +12 lines, -0 lines 1 comment Download
M src/codec/SkSwizzler.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/images/SkPNGImageEncoder.cpp View 4 chunks +27 lines, -1 line 0 comments Download
M tests/CodecTest.cpp View 1 chunk +12 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2059283002 Patch 120001

Messages

Total messages: 6 (4 generated)
msarett
Let me know what you think about this... https://codereview.chromium.org/2288163003/diff/20001/src/codec/SkPngCodec.cpp File src/codec/SkPngCodec.cpp (right): https://codereview.chromium.org/2288163003/diff/20001/src/codec/SkPngCodec.cpp#newcode770 src/codec/SkPngCodec.cpp:770: if ...
4 years, 3 months ago (2016-08-30 14:30:38 UTC) #5
msarett
4 years, 3 months ago (2016-09-09 18:40:35 UTC) #6 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698