Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2261213002: Detect all named gammas (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Detect all named gammas Our DstColorSpace UMA is showing some named gammas that are not appropriately detected and placed in named categories. https://uma.googleplex.com/p/chrome/histograms?endDate=latest&dayCount=1&histograms=Blink.ColorSpace.Destination&fixupData=true&showMax=true&filters=isofficial%2Ceq%2CTrue&implicitFilters=isofficial This CL should fix that. I'm not sure (yet) how I feel about this landing permanently. Seems a little messy. But it will be interesting to see how this affects the UMA. My best guess is that we are hitting this case when all three gammas are "invalid" in different ways. I'm expecting to see some profiles end up in the "invalid" category now. It's also possible that we'll see these cases being absorbed into sRGB or somewhere else. BUG=skia:5656 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261213002 Committed: https://skia.googlesource.com/skia/+/0f0c4f0902af265b74f4f679556e375e0ed8d944

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -7 lines) Patch
M src/core/SkColorSpace_ICC.cpp View 4 chunks +32 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
msarett
4 years, 4 months ago (2016-08-22 16:22:29 UTC) #5
mtklein
lgtm
4 years, 4 months ago (2016-08-22 16:28:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261213002/1
4 years, 4 months ago (2016-08-22 16:28:32 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 16:44:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0f0c4f0902af265b74f4f679556e375e0ed8d944

Powered by Google App Engine
This is Rietveld 408576698