Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2433323005: Fix for aggressive Chrome MSAN (Closed)

Created:
4 years, 2 months ago by msarett
Modified:
4 years, 2 months ago
Reviewers:
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix for aggressive Chrome MSAN I believe that the complaints are occurring because the |a| vector might be uninitialized where it is used here. It doesn't actually matter because we won't use or store that value - it's just a placeholder. But we need to make the bot happy. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2433323005

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkColorSpaceXform.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 2 (2 generated)
msarett
Description was changed from ========== Fix for aggressive Chrome MSAN I believe that the complaints ...
4 years, 2 months ago (2016-10-21 13:00:25 UTC) #1
msarett
4 years, 2 months ago (2016-10-21 13:01:57 UTC) #2
Description was changed from

==========
Fix for aggressive Chrome MSAN

I believe that the complaints are occurring because the |a| vector
might be uninitialized where it is used here.  It doesn't actually
matter because we won't use or store that value - it's just a
placeholder.

But we need to make the bot happy.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2433323005
==========

to

==========
Fix for aggressive Chrome MSAN

I believe that the complaints are occurring because the |a| vector
might be uninitialized where it is used here.  It doesn't actually
matter because we won't use or store that value - it's just a
placeholder.

But we need to make the bot happy.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2433323005
==========

Powered by Google App Engine
This is Rietveld 408576698