Parse ICC profiles from webps

Parse ICC profiles from webps

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2269333002

Committed: https://skia.googlesource.com/skia/+/9d15dab754f9d2633d34db041dc453249dd7e8ac

[msarett, 2016-08-23 22:41:02]

Description was changed from

==========
Parse ICC profiles from webps

BUG=skia:
==========

to

==========
Parse ICC profiles from webps

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2269333002
==========

[msarett, 2016-08-23 22:44:35]

msarett@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-08-24 12:56:50]

https://codereview.chromium.org/2269333002/diff/20001/src/codec/SkWebpCodec.cpp
File src/codec/SkWebpCodec.cpp (right):

https://codereview.chromium.org/2269333002/diff/20001/src/codec/SkWebpCodec.c...
src/codec/SkWebpCodec.cpp:109: WebPDemuxer* demux = WebPDemuxPartial(&data,
&state);
Might want to see what this all looks like using an SkAutoTCallVProc or two?

https://codereview.chromium.org/2269333002/diff/20001/src/codec/SkWebpCodec.c...
src/codec/SkWebpCodec.cpp:114: colorSpace = SkColorSpace::NewICC(profileData,
profileSize);
I might just skip some of the intermediate names here:

 colorspace = SkColorSpace::NewICC(chunkIterator.chunk.bytes,
chunkIterator.chunk.size);

https://codereview.chromium.org/2269333002/diff/20001/src/core/SkColorSpace_I...
File src/core/SkColorSpace_ICC.cpp (right):

https://codereview.chromium.org/2269333002/diff/20001/src/core/SkColorSpace_I...
src/core/SkColorSpace_ICC.cpp:141: if (fRenderingIntent > 3) {
Think we should land this separately, in case of reverts, etc?

[msarett, 2016-08-24 13:14:24]

Looks cleaner with the SkAutoTCallVProcs and without the local variables.

https://codereview.chromium.org/2269333002/diff/20001/src/codec/SkWebpCodec.cpp
File src/codec/SkWebpCodec.cpp (right):

https://codereview.chromium.org/2269333002/diff/20001/src/codec/SkWebpCodec.c...
src/codec/SkWebpCodec.cpp:109: WebPDemuxer* demux = WebPDemuxPartial(&data,
&state);
On 2016/08/24 12:56:50, mtklein wrote:
> Might want to see what this all looks like using an SkAutoTCallVProc or two?

Done.

https://codereview.chromium.org/2269333002/diff/20001/src/codec/SkWebpCodec.c...
src/codec/SkWebpCodec.cpp:114: colorSpace = SkColorSpace::NewICC(profileData,
profileSize);
On 2016/08/24 12:56:50, mtklein wrote:
> I might just skip some of the intermediate names here:
> 
>  colorspace = SkColorSpace::NewICC(chunkIterator.chunk.bytes,
> chunkIterator.chunk.size);

Done.

https://codereview.chromium.org/2269333002/diff/20001/src/core/SkColorSpace_I...
File src/core/SkColorSpace_ICC.cpp (right):

https://codereview.chromium.org/2269333002/diff/20001/src/core/SkColorSpace_I...
src/core/SkColorSpace_ICC.cpp:141: if (fRenderingIntent > 3) {
On 2016/08/24 12:56:50, mtklein wrote:
> Think we should land this separately, in case of reverts, etc?

Done.

[mtklein, 2016-08-24 14:02:15]

lgtm

[mtklein, 2016-08-24 14:02:20]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-08-24 14:02:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 14:03:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 14:03:55]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[msarett, 2016-08-24 14:10:25]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 14:10:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 14:32:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 14:32:21]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-08-24 14:34:58]

The CQ bit was checked by msarett@google.com

[msarett, 2016-08-24 14:34:59]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/2269333002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-24 14:35:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 14:36:08]

Description was changed from

==========
Parse ICC profiles from webps

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2269333002
==========

to

==========
Parse ICC profiles from webps

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2269333002

Committed:
https://skia.googlesource.com/skia/+/9d15dab754f9d2633d34db041dc453249dd7e8ac
==========

[commit-bot: I haz the power, 2016-08-24 14:36:09]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/9d15dab754f9d2633d34db041dc453249dd7e8ac