Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2261573002: Fix initialization bug for fConservativeIsScaleTranslate (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix initialization bug for fConservativeIsScaleTranslate Also don't mark it as conservative, we expect it to be correct all the time. TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261573002 Committed: https://skia.googlesource.com/skia/+/9637ea91b88ff8f8e95325bfc41417ffc4d5ee0b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M include/core/SkCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 7 chunks +8 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
msarett
4 years, 4 months ago (2016-08-18 20:45:21 UTC) #5
mtklein
lgtm
4 years, 4 months ago (2016-08-18 20:46:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261573002/1
4 years, 4 months ago (2016-08-18 21:02:41 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 21:03:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9637ea91b88ff8f8e95325bfc41417ffc4d5ee0b

Powered by Google App Engine
This is Rietveld 408576698