Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2274843002: Warn on bad rendering intents (instead of valid ones) (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Warn on bad rendering intents (instead of valid ones) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2274843002 Committed: https://skia.googlesource.com/skia/+/3bf7509c3f68aefbe5f8b2ea5888319a71a91d2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkColorSpace_ICC.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
msarett
4 years, 4 months ago (2016-08-24 13:01:41 UTC) #5
mtklein
lgtm
4 years, 4 months ago (2016-08-24 13:05:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274843002/1
4 years, 4 months ago (2016-08-24 13:21:47 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 13:22:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3bf7509c3f68aefbe5f8b2ea5888319a71a91d2d

Powered by Google App Engine
This is Rietveld 408576698