Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2336913005: Store SkColorSpaceXform gamma LUTs in a malloced field (Closed)

Created:
4 years, 3 months ago by msarett
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Store SkColorSpaceXform gamma LUTs in a malloced field In order of likelihood: (1) Tables are never used, since gamma is recognized and named. (2) Only use one table, since all three gammas are the same. (3) Actually need three tables. No reason to waste a bunch of space for these tables on SkColorSpaceXform, when it will likely be unused. This will be more efficient in lots of cases, but is particularly useful when the client really only wants a gamut xform. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336913005 Committed: https://skia.googlesource.com/skia/+/7bbda991af353fbe6b34132132d211d23a3dba8c

Patch Set 1 #

Patch Set 2 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -22 lines) Patch
M src/core/SkColorSpaceXform.h View 1 chunk +3 lines, -6 lines 0 comments Download
M src/core/SkColorSpaceXform.cpp View 1 6 chunks +55 lines, -16 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
msarett
4 years, 3 months ago (2016-09-14 15:31:51 UTC) #4
Brian Osman
lgtm
4 years, 3 months ago (2016-09-14 17:01:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336913005/20001
4 years, 3 months ago (2016-09-14 18:00:49 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/7bbda991af353fbe6b34132132d211d23a3dba8c
4 years, 3 months ago (2016-09-14 18:02:11 UTC) #13
mtklein_C
4 years, 3 months ago (2016-09-14 18:48:30 UTC) #15

Powered by Google App Engine
This is Rietveld 408576698