Avoid bitmap copy in SkMakeBitmapShader, fix hwui unit test

Avoid bitmap copy in SkMakeBitmapShader, fix hwui unit test

BUG:31594626
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355703003

[msarett, 2016-09-20 13:17:30]

Description was changed from

==========
Avoid bitmap copy in SkMakeBitmapShader, fix hwui unit test

BUG=skia:
==========

to

==========
Avoid bitmap copy in SkMakeBitmapShader, fix hwui unit test

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355703003
==========

[msarett, 2016-09-20 13:18:43]

msarett@google.com changed reviewers:
+ reed@google.com

[msarett, 2016-09-20 13:18:43]

I'm not sure what the correct fix is for this...  Let's discuss.

[msarett, 2016-09-20 13:19:04]

Description was changed from

==========
Avoid bitmap copy in SkMakeBitmapShader, fix hwui unit test

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355703003
==========

to

==========
Avoid bitmap copy in SkMakeBitmapShader, fix hwui unit test

BUG:31594626
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355703003
==========

[reed1, 2016-09-20 17:19:06]

https://codereview.chromium.org/2355703003/diff/1/src/image/SkImageShader.cpp
File src/image/SkImageShader.cpp (right):

https://codereview.chromium.org/2355703003/diff/1/src/image/SkImageShader.cpp...
src/image/SkImageShader.cpp:100: #if 1
what was wrong with the FRAMEWORK flag?

https://codereview.chromium.org/2355703003/diff/1/src/image/SkImageShader.cpp...
src/image/SkImageShader.cpp:247: return
SkImageShader::Make(SkMakeImageFromRasterBitmap(src, kNever_SkCopyPixelsMode,
allocator),
Can the caller make the decision to pass in kNever, instead of hard-coding it?

https://codereview.chromium.org/2355703003/diff/1/tests/ShaderTest.cpp
File tests/ShaderTest.cpp (right):

https://codereview.chromium.org/2355703003/diff/1/tests/ShaderTest.cpp#newcode69
tests/ShaderTest.cpp:69: sk_sp<SkShader> s =
SkShader::MakeBitmapShader(origBitmap, SkShader::kClamp_TileMode,
Tests are allowed to call private APIs, e.g. SkImagePriv.h

[msarett, 2016-09-20 17:20:22]

On 2016/09/20 17:19:06, reed1 wrote:
> https://codereview.chromium.org/2355703003/diff/1/src/image/SkImageShader.cpp
> File src/image/SkImageShader.cpp (right):
> 
>
https://codereview.chromium.org/2355703003/diff/1/src/image/SkImageShader.cpp...
> src/image/SkImageShader.cpp:100: #if 1
> what was wrong with the FRAMEWORK flag?
> 
>
https://codereview.chromium.org/2355703003/diff/1/src/image/SkImageShader.cpp...
> src/image/SkImageShader.cpp:247: return
> SkImageShader::Make(SkMakeImageFromRasterBitmap(src, kNever_SkCopyPixelsMode,
> allocator),
> Can the caller make the decision to pass in kNever, instead of hard-coding it?
> 
> https://codereview.chromium.org/2355703003/diff/1/tests/ShaderTest.cpp
> File tests/ShaderTest.cpp (right):
> 
>
https://codereview.chromium.org/2355703003/diff/1/tests/ShaderTest.cpp#newcode69
> tests/ShaderTest.cpp:69: sk_sp<SkShader> s =
> SkShader::MakeBitmapShader(origBitmap, SkShader::kClamp_TileMode,
> Tests are allowed to call private APIs, e.g. SkImagePriv.h

Sorry this is closed, was just experimenting to replicate the framework failures
and see how to fix them.  This is fixed by calling SkMakeBitmapSahder() from the
framework.