Reduce CPU overhead on drawRegion()

Reduce CPU overhead on drawRegion()

Only batch when the view matrices are the same.

This allows us to skip applying the matrix and uploading
local coords.

drawregion Bench on Nexus 6P:
Before 4.69ms
After  2.83ms

This puts SkiaGL nearly on par with OpenGL.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282983003

Committed: https://skia.googlesource.com/skia/+/febb22469999b928850182ebc57bfd6fbd7402d6

[msarett, 2016-08-26 18:04:05]

Description was changed from

==========
Reduce CPU overhead on drawRegion()

BUG=skia:
==========

to

==========
Reduce CPU overhead on drawRegion()

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282983003
==========

[msarett, 2016-08-26 18:21:39]

Description was changed from

==========
Reduce CPU overhead on drawRegion()

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282983003
==========

to

==========
Reduce CPU overhead on drawRegion()

Only batch when the view matrices are the same.

This allows us to skip applying the matrix and uploading
local coords.

drawregion Bench on Nexus 6P:
Before 4.69ms
After  2.83ms

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282983003
==========

[msarett, 2016-08-26 18:24:20]

Patchset #1 (id:1) has been deleted

[msarett, 2016-08-26 18:24:38]

Patchset #1 (id:20001) has been deleted

[msarett, 2016-08-26 18:41:33]

Description was changed from

==========
Reduce CPU overhead on drawRegion()

Only batch when the view matrices are the same.

This allows us to skip applying the matrix and uploading
local coords.

drawregion Bench on Nexus 6P:
Before 4.69ms
After  2.83ms

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282983003
==========

to

==========
Reduce CPU overhead on drawRegion()

Only batch when the view matrices are the same.

This allows us to skip applying the matrix and uploading
local coords.

drawregion Bench on Nexus 6P:
Before 4.69ms
After  2.83ms

This puts SkiaGL nearly on par with OpenGL.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282983003
==========

[msarett, 2016-08-26 18:41:54]

msarett@google.com changed reviewers:
+ bsalomon@google.com, djsollen@google.com

[msarett, 2016-08-26 18:41:55]

https://codereview.chromium.org/2282983003/diff/40001/gm/drawregion.cpp
File gm/drawregion.cpp (right):

https://codereview.chromium.org/2282983003/diff/40001/gm/drawregion.cpp#newco...
gm/drawregion.cpp:40: canvas->translate(10, 10);
Applying the view matrix is a no-op when it's identity...

This translate allows the bench to show the cost of applying the matrix.

[bsalomon, 2016-08-26 19:11:25]

lgtm

[msarett, 2016-08-26 19:23:17]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 19:23:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 19:48:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 19:48:18]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-08-26 19:48:32]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-08-26 19:48:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 19:49:30]

Description was changed from

==========
Reduce CPU overhead on drawRegion()

Only batch when the view matrices are the same.

This allows us to skip applying the matrix and uploading
local coords.

drawregion Bench on Nexus 6P:
Before 4.69ms
After  2.83ms

This puts SkiaGL nearly on par with OpenGL.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282983003
==========

to

==========
Reduce CPU overhead on drawRegion()

Only batch when the view matrices are the same.

This allows us to skip applying the matrix and uploading
local coords.

drawregion Bench on Nexus 6P:
Before 4.69ms
After  2.83ms

This puts SkiaGL nearly on par with OpenGL.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282983003

Committed:
https://skia.googlesource.com/skia/+/febb22469999b928850182ebc57bfd6fbd7402d6
==========

[commit-bot: I haz the power, 2016-08-26 19:49:31]

Committed patchset #1 (id:40001) as
https://skia.googlesource.com/skia/+/febb22469999b928850182ebc57bfd6fbd7402d6