Delete SkColorSpace::gammaNamed() from public API

Delete SkColorSpace::gammaNamed() from public API

Move fGammaNamed to SkColorSpace_Base.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318663003

Committed: https://skia.googlesource.com/skia/+/600c737b64eae2c7379442ae2c852853cce3a278

[msarett, 2016-09-06 17:37:45]

Description was changed from

==========
Delete SkColorSpace::kNonStandard_GammaNamed from public API

BUG=skia:
==========

to

==========
Delete SkColorSpace::kNonStandard_GammaNamed from public API

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318663003
==========

[msarett, 2016-09-06 17:58:41]

Patchset #1 (id:1) has been deleted

[msarett, 2016-09-06 19:03:26]

Patchset #2 (id:40001) has been deleted

[msarett, 2016-09-06 19:05:43]

Description was changed from

==========
Delete SkColorSpace::kNonStandard_GammaNamed from public API

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318663003
==========

to

==========
Delete SkColorSpace::kNonStandard_GammaNamed and k2Dot2 from public API

Move fGammaNamed to SkColorSpace_Base.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318663003
==========

[msarett, 2016-09-06 19:07:02]

msarett@google.com changed reviewers:
+ brianosman@google.com, reed@google.com

[msarett, 2016-09-06 19:07:03]

I feel good about the API changes...  Let me know what you think.

Not quite as sure about having two similar enums.

https://codereview.chromium.org/2318663003/diff/60001/include/core/SkColorSpa...
File include/core/SkColorSpace.h (right):

https://codereview.chromium.org/2318663003/diff/60001/include/core/SkColorSpa...
include/core/SkColorSpace.h:74: bool gammaCloseToSRGB() const;
Patch Set 1 keeps the fGammaNamed field and k2Dot2, so we can still inline this
function.

[reed1, 2016-09-06 19:11:15]

api lgtm

[msarett, 2016-09-06 19:31:42]

*Added sanity check to NewRGB
*Dropped weird casting between enums

[msarett, 2016-09-06 19:31:49]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 19:31:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 19:43:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 19:43:50]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[msarett, 2016-09-06 20:08:04]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 20:08:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 21:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 21:09:40]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[msarett, 2016-09-06 23:00:15]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 23:00:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 23:01:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 23:01:45]

Dry run: Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[msarett, 2016-09-06 23:07:48]

This can land now that I've fixed Chrome.

In comments I tried to point out the interesting parts of
this change - to help parse from the millions of name
changes.

https://codereview.chromium.org/2318663003/diff/100001/src/core/SkColorSpace.cpp
File src/core/SkColorSpace.cpp (right):

https://codereview.chromium.org/2318663003/diff/100001/src/core/SkColorSpace....
src/core/SkColorSpace.cpp:125: switch (gammaNamed) {
Convert public gamma enum to the private one.

https://codereview.chromium.org/2318663003/diff/100001/src/core/SkColorSpace....
src/core/SkColorSpace.cpp:176: bool SkColorSpace::gammaCloseToSRGB() const {
Can't inline these anymore.

https://codereview.chromium.org/2318663003/diff/100001/src/core/SkColorSpace_...
File src/core/SkColorSpace_Base.h (right):

https://codereview.chromium.org/2318663003/diff/100001/src/core/SkColorSpace_...
src/core/SkColorSpace_Base.h:15: enum SkGammaNamed : uint8_t {
Added a new SkGammaNamed enum.

https://codereview.chromium.org/2318663003/diff/100001/src/core/SkColorSpace_...
src/core/SkColorSpace_Base.h:69: SkGammaNamed             fNamed;
SkGammaNamed enum stored on SkColorSpace_Base.

[msarett, 2016-09-06 23:10:21]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 23:10:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 00:18:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 00:18:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[msarett, 2016-09-07 14:28:58]

Description was changed from

==========
Delete SkColorSpace::kNonStandard_GammaNamed and k2Dot2 from public API

Move fGammaNamed to SkColorSpace_Base.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318663003
==========

to

==========
Delete SkColorSpace::gammaNamed() from public API

Move fGammaNamed to SkColorSpace_Base.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318663003
==========

[Brian Osman, 2016-09-07 14:48:02]

lgtm

[msarett, 2016-09-07 17:49:58]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 17:50:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msarett, 2016-09-07 18:40:39]

The CQ bit was unchecked by msarett@google.com

[msarett, 2016-09-07 18:47:21]

The CQ bit was checked by msarett@google.com

[msarett, 2016-09-07 18:47:21]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/2318663003/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-07 18:47:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 19:03:55]

Description was changed from

==========
Delete SkColorSpace::gammaNamed() from public API

Move fGammaNamed to SkColorSpace_Base.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318663003
==========

to

==========
Delete SkColorSpace::gammaNamed() from public API

Move fGammaNamed to SkColorSpace_Base.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318663003

Committed:
https://skia.googlesource.com/skia/+/600c737b64eae2c7379442ae2c852853cce3a278
==========

[commit-bot: I haz the power, 2016-09-07 19:03:56]

Committed patchset #6 (id:140001) as
https://skia.googlesource.com/skia/+/600c737b64eae2c7379442ae2c852853cce3a278