Add SkColorSpacePrimaries to help with making D50 matrices

Add SkColorSpacePrimaries to help with making D50 matrices

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2304753002

Committed: https://skia.googlesource.com/skia/+/a5a31dd99467604f345850881dc8540c62aa506c

[msarett, 2016-09-02 00:28:48]

Description was changed from

==========
Sketch of new constructors for SkColorSpace

BUG=skia:
==========

to

==========
Sketch of new constructors for SkColorSpace

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2304753002
==========

[msarett, 2016-09-02 00:36:39]

msarett@google.com changed reviewers:
+ reed@google.com

[msarett, 2016-09-02 00:36:39]

Let's discuss tomorrow...

[msarett, 2016-09-02 15:07:09]

msarett@google.com changed reviewers:
+ brianosman@google.com

[Brian Osman, 2016-09-02 15:37:53]

https://codereview.chromium.org/2304753002/diff/20001/include/core/SkColorSpa...
File include/core/SkColorSpace.h (right):

https://codereview.chromium.org/2304753002/diff/20001/include/core/SkColorSpa...
include/core/SkColorSpace.h:90: static sk_sp<SkColorSpace> NewRGB(GammaNamed
gammaNamed, const Primaries& primaries);
I already mentioned this to Matt, but this set of factories (and this one in
particular) will be super useful to me for testing. This format of data
(primaries w/ white point) is the easiest and canonical way to find/express
various gamuts. It bypasses all the problems with distributing (potentially
copyrighted) ICC profiles.

And for applications written in Skia, we're going to need to mix those gamuts
with other gammas - if someone wants to work in "DCI P3" for example, they're
still going to have to settle for the sRGB transfer function (in 8-bit) or
linear (in FP16), so this makes it even easier to directly construct any such
combination.

[msarett, 2016-09-06 22:12:30]

Please take a look.  I've rebased on my latest clean-ups and added SkPrimaries
and SkTransferFn.

[reed1, 2016-09-06 23:19:48]

https://codereview.chromium.org/2304753002/diff/80001/include/core/SkColorSpa...
File include/core/SkColorSpace.h (right):

https://codereview.chromium.org/2304753002/diff/80001/include/core/SkColorSpa...
include/core/SkColorSpace.h:34: SkPrimaries(Named named) {
like not inlined, right?

https://codereview.chromium.org/2304753002/diff/80001/include/core/SkColorSpa...
include/core/SkColorSpace.h:149: static bool PrimariesToXYZD50(SkMatrix44*
/*toXYZD50*/, const SkPrimaries& /*primaries*/) {
can/should this be a method on primaries?

[msarett, 2016-09-07 14:01:21]

https://codereview.chromium.org/2304753002/diff/80001/include/core/SkColorSpa...
File include/core/SkColorSpace.h (right):

https://codereview.chromium.org/2304753002/diff/80001/include/core/SkColorSpa...
include/core/SkColorSpace.h:34: SkPrimaries(Named named) {
On 2016/09/06 23:19:48, reed1 wrote:
> like not inlined, right?

Yes, not here.

I've added a default constructor and improved the comment.

https://codereview.chromium.org/2304753002/diff/80001/include/core/SkColorSpa...
include/core/SkColorSpace.h:149: static bool PrimariesToXYZD50(SkMatrix44*
/*toXYZD50*/, const SkPrimaries& /*primaries*/) {
On 2016/09/06 23:19:48, reed1 wrote:
> can/should this be a method on primaries?

Yes, works for me.

[msarett, 2016-09-07 19:14:07]

Patchset #7 (id:120001) has been deleted

[msarett, 2016-09-07 22:12:35]

Patchset #8 (id:160001) has been deleted

[msarett, 2016-09-07 22:13:36]

How does this look?

[reed1, 2016-09-07 22:50:45]

possibly need more clear names...

SkColorSpacePrimaries ?

https://codereview.chromium.org/2304753002/diff/180001/include/core/SkColorSp...
File include/core/SkColorSpace.h (right):

https://codereview.chromium.org/2304753002/diff/180001/include/core/SkColorSp...
include/core/SkColorSpace.h:30: static bool PrimariesToXYZD50(SkMatrix44*
toXYZD50, const SkPrimaries& primaries);
nit: doesn't need to be static:

bool toXYZD50(SkMatrix44*) const;

[msarett, 2016-09-08 02:24:09]

Clearer names sgtm.  Went with SkColorSpacePrimaries and SkColorSpaceTransferFn.

https://codereview.chromium.org/2304753002/diff/180001/include/core/SkColorSp...
File include/core/SkColorSpace.h (right):

https://codereview.chromium.org/2304753002/diff/180001/include/core/SkColorSp...
include/core/SkColorSpace.h:30: static bool PrimariesToXYZD50(SkMatrix44*
toXYZD50, const SkPrimaries& primaries);
On 2016/09/07 22:50:45, reed1 wrote:
> nit: doesn't need to be static:
> 
> bool toXYZD50(SkMatrix44*) const;

Done.

[msarett, 2016-09-08 12:30:29]

Patchset #10 (id:220001) has been deleted

[reed1, 2016-09-08 14:43:01]

lgtm

[msarett, 2016-09-29 21:02:13]

Think I should go ahead and try to land these?

[Brian Osman, 2016-09-30 18:27:59]

On 2016/09/29 21:02:13, msarett wrote:
> Think I should go ahead and try to land these?

I think so, yes.

[msarett, 2016-10-10 22:17:40]

Patchset #13 (id:300001) has been deleted

[msarett, 2016-10-10 22:19:08]

Description was changed from

==========
Sketch of new constructors for SkColorSpace

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2304753002
==========

to

==========
Add SkColorSpacePrimaries to help with making D50 matrices

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2304753002
==========

[msarett, 2016-10-10 22:19:48]

PTAL
Changed this to only add SkColorSpacePrimaries.
Added implementation and test.

[reed1, 2016-10-11 01:47:58]

api lgtm

[Brian Osman, 2016-10-11 15:50:11]

lgtm

[msarett, 2016-10-11 15:51:40]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 15:51:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 15:54:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 15:54:56]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[msarett, 2016-10-11 16:05:02]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 16:05:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 16:27:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 16:27:42]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-10-11 16:39:54]

The CQ bit was checked by msarett@google.com

[msarett, 2016-10-11 16:39:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
brianosman@google.com, reed@google.com
Link to the patchset: https://codereview.chromium.org/2304753002/#ps340001
(title: "Fix compile bug")

[commit-bot: I haz the power, 2016-10-11 16:40:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 16:41:18]

Description was changed from

==========
Add SkColorSpacePrimaries to help with making D50 matrices

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2304753002
==========

to

==========
Add SkColorSpacePrimaries to help with making D50 matrices

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2304753002

Committed:
https://skia.googlesource.com/skia/+/a5a31dd99467604f345850881dc8540c62aa506c
==========

[commit-bot: I haz the power, 2016-10-11 16:41:19]

Committed patchset #14 (id:340001) as
https://skia.googlesource.com/skia/+/a5a31dd99467604f345850881dc8540c62aa506c