Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2413383002: Cache dst LUTs in SkColorSpaceXform (Closed)

Created:
4 years, 2 months ago by msarett
Modified:
4 years, 2 months ago
Reviewers:
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Cache dst LUTs in SkColorSpaceXform This is only useful in the rare case that the dst does not fall into one of our main paths. But it's a useful optimization, since this does happen, and typically, the dst won't change. ColorCodecBench z620 --nonstd --xform_only Without Patch 511us With Patch 348us BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2413383002

Patch Set 1 #

Patch Set 2 : Add a unique id to SkColorSpace #

Patch Set 3 : Better implementation of unique id #

Patch Set 4 : Ref the storage on SkColorSpaceXform #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -66 lines) Patch
M bench/ColorCodecBench.cpp View 1 2 chunks +8 lines, -0 lines 0 comments Download
M include/core/SkColorSpaceXform.h View 1 chunk +1 line, -7 lines 0 comments Download
M src/core/SkColorSpace.cpp View 1 2 3 2 chunks +18 lines, -0 lines 0 comments Download
M src/core/SkColorSpaceXform.cpp View 1 2 3 9 chunks +47 lines, -39 lines 0 comments Download
M src/core/SkColorSpaceXform_Base.h View 1 2 3 2 chunks +22 lines, -7 lines 0 comments Download
M src/core/SkColorSpace_Base.h View 1 2 3 2 chunks +13 lines, -7 lines 0 comments Download
M tests/ColorSpaceXformTest.cpp View 1 7 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (2 generated)
msarett
Description was changed from ========== Cache dst LUTs in SkColorSpaceXform This is only useful in ...
4 years, 2 months ago (2016-10-13 21:22:53 UTC) #1
msarett
4 years, 2 months ago (2016-10-13 21:32:05 UTC) #2 
Description was changed from

==========
Cache dst LUTs in SkColorSpaceXform

This is only useful in the rare case that the dst does not
fall into one of our main paths.

But it's a useful optimization, since this does happen,
and typically, the dst won't change.

ColorCodecBench z620 --nonstd --xform_only
Without Patch 511us
With Patch    348us

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2413383002
==========

to

==========
Cache dst LUTs in SkColorSpaceXform

This is only useful in the rare case that the dst does not
fall into one of our main paths.

But it's a useful optimization, since this does happen,
and typically, the dst won't change.

ColorCodecBench z620 --nonstd --xform_only
Without Patch 511us
With Patch    348us

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2413383002
==========

Powered by Google App Engine
This is Rietveld 408576698