Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2293633003:
Skip spinlock overhead on Android (Closed)
DescriptionSkip spinlock overhead on Android
Using the spinlock is only necessary when we multiple threads
might use a GrContext. Android uses the GrContext from a
single thread, so these locks are not needed.
This is a temporary fix until we can refactor to avoid
creating GrContexts in a global memory pool.
BUG=skia:5696
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293633003
Committed: https://skia.googlesource.com/skia/+/68440f8ce90a48e14e79b6fe5a6dd47c8c09bfb4
Patch Set 1 #Patch Set 2 : Add comments #
Depends on Patchset: Messages
Total messages: 23 (17 generated)
Description was changed from ========== Skip spinlock overhead on Android BUG=skia: ========== to ========== Skip spinlock overhead on Android BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293633003 ==========
msarett@google.com changed reviewers: + bsalomon@google.com, djsollen@google.com
Description was changed from ========== Skip spinlock overhead on Android BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293633003 ========== to ========== Skip spinlock overhead on Android Using the spinlock is only necessary when we multiple threads might use a GrContext. Android uses the GrContext from a single thread, so these locks are not needed. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293633003 ==========
Description was changed from ========== Skip spinlock overhead on Android Using the spinlock is only necessary when we multiple threads might use a GrContext. Android uses the GrContext from a single thread, so these locks are not needed. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293633003 ========== to ========== Skip spinlock overhead on Android Using the spinlock is only necessary when we multiple threads might use a GrContext. Android uses the GrContext from a single thread, so these locks are not needed. This is a temporary fix until we can refactor to avoid creating GrContexts in a global memory pool. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293633003 ==========
Updated CL description
Can we add a comment like // We know in the Android framework there is only one GrContext. lgtm
On 2016/08/29 21:09:10, bsalomon wrote: > Can we add a comment like // We know in the Android framework there is only one > GrContext. > > lgtm Comments added.
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Skip spinlock overhead on Android Using the spinlock is only necessary when we multiple threads might use a GrContext. Android uses the GrContext from a single thread, so these locks are not needed. This is a temporary fix until we can refactor to avoid creating GrContexts in a global memory pool. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293633003 ========== to ========== Skip spinlock overhead on Android Using the spinlock is only necessary when we multiple threads might use a GrContext. Android uses the GrContext from a single thread, so these locks are not needed. This is a temporary fix until we can refactor to avoid creating GrContexts in a global memory pool. BUG=skia:5696 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293633003 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msarett@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com Link to the patchset: https://codereview.chromium.org/2293633003/#ps40001 (title: "Add comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Skip spinlock overhead on Android Using the spinlock is only necessary when we multiple threads might use a GrContext. Android uses the GrContext from a single thread, so these locks are not needed. This is a temporary fix until we can refactor to avoid creating GrContexts in a global memory pool. BUG=skia:5696 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293633003 ========== to ========== Skip spinlock overhead on Android Using the spinlock is only necessary when we multiple threads might use a GrContext. Android uses the GrContext from a single thread, so these locks are not needed. This is a temporary fix until we can refactor to avoid creating GrContexts in a global memory pool. BUG=skia:5696 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293633003 Committed: https://skia.googlesource.com/skia/+/68440f8ce90a48e14e79b6fe5a6dd47c8c09bfb4 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://skia.googlesource.com/skia/+/68440f8ce90a48e14e79b6fe5a6dd47c8c09bfb4 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
