Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2319293002: Rename SkColorSpace::GammaNamed to SkColorSpace::RenderTargetGamma (Closed)

Created:
4 years, 3 months ago by msarett
Modified:
4 years, 3 months ago
Reviewers:
Brian Osman, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename SkColorSpace::GammaNamed to SkColorSpace::RenderTargetGamma BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319293002 Committed: https://skia.googlesource.com/skia/+/48ba2b8550d0d243dddf728b602995b01bc137e1

Patch Set 1 #

Patch Set 2 : Keep compatible with Chrome #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -17 lines) Patch
M gm/color4f.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/gamut.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkColorSpace.h View 1 1 chunk +8 lines, -5 lines 0 comments Download
M src/codec/SkPngCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkColorSpace.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/ColorSpaceTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
msarett
4 years, 3 months ago (2016-09-07 22:02:38 UTC) #3
reed1
api lgtm
4 years, 3 months ago (2016-09-07 22:48:16 UTC) #7
msarett
Going to have to jump through hoops to roll this into Chrome...
4 years, 3 months ago (2016-09-08 01:12:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319293002/20001
4 years, 3 months ago (2016-09-08 01:54:57 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 01:55:54 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/48ba2b8550d0d243dddf728b602995b01bc137e1

Powered by Google App Engine
This is Rietveld 408576698