Delete SkColorSpace::kUnknown_Named, remove fNamed field

Delete SkColorSpace::kUnknown_Named, remove fNamed field

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302413002

Committed: https://skia.googlesource.com/skia/+/54682e856cb66c653bc7e253981a421a2618398e
Committed: https://skia.googlesource.com/skia/+/47ae5c5d8f01111dad6694aaa3a3dee1ed6e677e

[msarett, 2016-09-02 17:55:16]

Description was changed from

==========
Delete SkColorSpace::kUnknown_Named, remove fNamed field

BUG=skia:
==========

to

==========
Delete SkColorSpace::kUnknown_Named, remove fNamed field

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302413002
==========

[msarett, 2016-09-02 17:56:38]

Patchset #1 (id:1) has been deleted

[msarett, 2016-09-02 18:01:20]

msarett@google.com changed reviewers:
+ brianosman@google.com, reed@google.com

[msarett, 2016-09-02 18:01:21]

Let me know what you think about this...

https://codereview.chromium.org/2302413002/diff/20001/src/core/SkColorSpace.cpp
File src/core/SkColorSpace.cpp (right):

https://codereview.chromium.org/2302413002/diff/20001/src/core/SkColorSpace.c...
src/core/SkColorSpace.cpp:245: ColorSpaceHeader::Pack(k0_Version, 0,
fGammaNamed,
For safety, should be write something that is less likely to be a value in the
enum?

[reed1, 2016-09-02 18:23:10]

no rush, but lgtm for me

[msarett, 2016-09-02 20:57:50]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 20:57:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 21:23:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 21:23:22]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-09-02 21:24:10]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-09-02 21:24:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 21:25:08]

Description was changed from

==========
Delete SkColorSpace::kUnknown_Named, remove fNamed field

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302413002
==========

to

==========
Delete SkColorSpace::kUnknown_Named, remove fNamed field

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302413002

Committed:
https://skia.googlesource.com/skia/+/54682e856cb66c653bc7e253981a421a2618398e
==========

[commit-bot: I haz the power, 2016-09-02 21:25:09]

Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/54682e856cb66c653bc7e253981a421a2618398e

[Matt Giuca, 2016-09-05 04:47:47]

A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/2306313002/ by mgiuca@chromium.org.

The reason for reverting is: This CL introduced two static initializers
(gAdobeRGB and gSRGB) which are causing a sizes regression on Chromium builders:

https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/24981.

[msarett, 2016-09-05 17:14:24]

Description was changed from

==========
Delete SkColorSpace::kUnknown_Named, remove fNamed field

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302413002

Committed:
https://skia.googlesource.com/skia/+/54682e856cb66c653bc7e253981a421a2618398e
==========

to

==========
Delete SkColorSpace::kUnknown_Named, remove fNamed field

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302413002

Committed:
https://skia.googlesource.com/skia/+/54682e856cb66c653bc7e253981a421a2618398e
==========

[msarett, 2016-09-06 15:32:34]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 15:32:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msarett, 2016-09-06 15:34:47]

msarett@google.com changed reviewers:
+ mtklein@google.com

[msarett, 2016-09-06 15:34:47]

Refactored to use a static function to contain the once-ptr logic.

+mtklein in case there is a better way to do this.

[commit-bot: I haz the power, 2016-09-06 16:05:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 16:05:51]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-09-06 16:18:03]

Patchset #2 (id:40001) has been deleted

[msarett, 2016-09-06 16:28:33]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 16:28:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 16:59:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 16:59:29]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-09-06 17:00:40]

Using a bare ptr now.

[msarett, 2016-09-06 17:00:44]

The CQ bit was checked by msarett@google.com

[msarett, 2016-09-06 17:00:45]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/2302413002/#ps80001
(title: "Use a bare ptr instead of an sk_sp")

[commit-bot: I haz the power, 2016-09-06 17:00:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 17:01:50]

Description was changed from

==========
Delete SkColorSpace::kUnknown_Named, remove fNamed field

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302413002

Committed:
https://skia.googlesource.com/skia/+/54682e856cb66c653bc7e253981a421a2618398e
==========

to

==========
Delete SkColorSpace::kUnknown_Named, remove fNamed field

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302413002

Committed:
https://skia.googlesource.com/skia/+/54682e856cb66c653bc7e253981a421a2618398e
Committed:
https://skia.googlesource.com/skia/+/47ae5c5d8f01111dad6694aaa3a3dee1ed6e677e
==========

[commit-bot: I haz the power, 2016-09-06 17:01:51]

Committed patchset #3 (id:80001) as
https://skia.googlesource.com/skia/+/47ae5c5d8f01111dad6694aaa3a3dee1ed6e677e