More robust check for sRGB gamma tables

More robust check for sRGB gamma tables

This is in response to a UMA showing that 5% dst gammas are
unidentified tables.  We want to see if some of these tables
should be marked as sRGB.
https://uma.googleplex.com/p/chrome/histograms?endDate=latest&dayCount=1&histograms=Blink.ColorSpace.Destination&fixupData=true&showMax=true&filters=isofficial%2Ceq%2CTrue&implicitFilters=isofficial

This check is not fast.  If we find that it doesn't help
us recognize sRGB curves, we should delete it.

BUG=skia:5656
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263233003

Committed: https://skia.googlesource.com/skia/+/4ff08df15a8042cdb4fc90a82e1044847d0de300

[msarett, 2016-08-22 18:12:53]

Description was changed from

==========
More robust check for sRGB gamma tables

This is in response to a UMA showing that 5% dst gammas are
unidentified tables.  We want to see if some of these tables
should be marked as sRGB.
https://uma.googleplex.com/p/chrome/histograms?endDate=latest&dayCount=1&hist...

This check is not fast.  If we find that it doesn't help
us recognize sRGB curves, we should delete it.

BUG=skia:5656
==========

to

==========
More robust check for sRGB gamma tables

This is in response to a UMA showing that 5% dst gammas are
unidentified tables.  We want to see if some of these tables
should be marked as sRGB.
https://uma.googleplex.com/p/chrome/histograms?endDate=latest&dayCount=1&hist...

This check is not fast.  If we find that it doesn't help
us recognize sRGB curves, we should delete it.

BUG=skia:5656
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263233003
==========

[msarett, 2016-08-22 18:18:09]

Patchset #1 (id:1) has been deleted

[msarett, 2016-08-22 18:23:49]

Patchset #1 (id:20001) has been deleted

[msarett, 2016-08-22 18:24:46]

msarett@google.com changed reviewers:
+ brianosman@google.com, mtklein@google.com

[mtklein, 2016-08-22 20:27:59]

https://codereview.chromium.org/2263233003/diff/40001/src/core/SkColorSpace_I...
File src/core/SkColorSpace_ICC.cpp (right):

https://codereview.chromium.org/2263233003/diff/40001/src/core/SkColorSpace_I...
src/core/SkColorSpace_ICC.cpp:390: uint16_t srgbY =
sk_float_round2int(SkFloatToFixed(srgb_fn(x)));
wtf

[msarett, 2016-08-22 21:15:39]

https://codereview.chromium.org/2263233003/diff/40001/src/core/SkColorSpace_I...
File src/core/SkColorSpace_ICC.cpp (right):

https://codereview.chromium.org/2263233003/diff/40001/src/core/SkColorSpace_I...
src/core/SkColorSpace_ICC.cpp:390: uint16_t srgbY =
sk_float_round2int(SkFloatToFixed(srgb_fn(x)));
On 2016/08/22 20:27:59, mtklein wrote:
> wtf

Hopefully it's a little clearer now :)

[mtklein, 2016-08-22 21:36:00]

oh thank you yes

lgtm

[msarett, 2016-08-22 21:36:59]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 21:37:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 21:57:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 21:57:32]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-08-22 21:57:59]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-08-22 21:58:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 21:58:58]

Description was changed from

==========
More robust check for sRGB gamma tables

This is in response to a UMA showing that 5% dst gammas are
unidentified tables.  We want to see if some of these tables
should be marked as sRGB.
https://uma.googleplex.com/p/chrome/histograms?endDate=latest&dayCount=1&hist...

This check is not fast.  If we find that it doesn't help
us recognize sRGB curves, we should delete it.

BUG=skia:5656
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263233003
==========

to

==========
More robust check for sRGB gamma tables

This is in response to a UMA showing that 5% dst gammas are
unidentified tables.  We want to see if some of these tables
should be marked as sRGB.
https://uma.googleplex.com/p/chrome/histograms?endDate=latest&dayCount=1&hist...

This check is not fast.  If we find that it doesn't help
us recognize sRGB curves, we should delete it.

BUG=skia:5656
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263233003

Committed:
https://skia.googlesource.com/skia/+/4ff08df15a8042cdb4fc90a82e1044847d0de300
==========

[commit-bot: I haz the power, 2016-08-22 21:58:59]

Committed patchset #2 (id:60001) as
https://skia.googlesource.com/skia/+/4ff08df15a8042cdb4fc90a82e1044847d0de300

[msarett, 2016-09-06 20:25:19]

A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.chromium.org/2315863003/ by msarett@google.com.

The reason for reverting is: From the previous commit message:
"This check is not fast.  If we find that it doesn't help
us recognize sRGB curves, we should delete it."

Turns out it doesn't help.  Looks to me like the tables are not sRGB..