Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2360863003: Make SkColorSpaceXform::New() take bare ptrs (Closed)

Created:
4 years, 3 months ago by msarett
Modified:
4 years, 3 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkColorSpaceXform::New() take bare ptrs There's no need to take sk_sp if we're not going to ref the ptr. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360863003 Committed: https://skia.googlesource.com/skia/+/4be0e7cfe0efceeaf4c7a4d598d77c27cfd3e69b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -27 lines) Patch
M bench/ColorCodecBench.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/colorspacexform.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/codec/SkPngCodec.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/codec/SkWebpCodec.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkColorSpaceXform.h View 3 chunks +5 lines, -6 lines 0 comments Download
M src/core/SkColorSpaceXform.cpp View 5 chunks +9 lines, -10 lines 0 comments Download
M tests/ColorSpaceXformTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
msarett
4 years, 3 months ago (2016-09-22 13:07:15 UTC) #6
mtklein
lgtm
4 years, 3 months ago (2016-09-22 13:12:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360863003/1
4 years, 3 months ago (2016-09-22 14:01:02 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 14:02:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4be0e7cfe0efceeaf4c7a4d598d77c27cfd3e69b

Powered by Google App Engine
This is Rietveld 408576698