Fix generic color space xform, ColorSpaceXformTest

Fix generic color space xform, ColorSpaceXformTest

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275563002

Committed: https://skia.googlesource.com/skia/+/9dc6cf6b8833d36c29a23d2519989b069745fcd5

[msarett, 2016-08-23 14:01:16]

Description was changed from

==========
Fix generic color space xform, ColorSpaceXformTest

BUG=skia:
==========

to

==========
Fix generic color space xform, ColorSpaceXformTest

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275563002
==========

[msarett, 2016-08-23 14:03:11]

msarett@google.com changed reviewers:
+ mtklein@google.com

[msarett, 2016-08-23 14:03:12]

https://codereview.chromium.org/2275563002/diff/1/tests/ColorSpaceXformTest.cpp
File tests/ColorSpaceXformTest.cpp (left):

https://codereview.chromium.org/2275563002/diff/1/tests/ColorSpaceXformTest.c...
tests/ColorSpaceXformTest.cpp:22: return SkColorSpaceXform::New(space, space);
This test became useless when we added opts for space == space.

https://codereview.chromium.org/2275563002/diff/1/tests/ColorSpaceXformTest.cpp
File tests/ColorSpaceXformTest.cpp (right):

https://codereview.chromium.org/2275563002/diff/1/tests/ColorSpaceXformTest.c...
tests/ColorSpaceXformTest.cpp:45: xform->apply(dstPixels, srcPixels, width,
kN32_SkColorType, kOpaque_SkAlphaType);
Turns out only testing RGBA->RGBA is a bad idea...

[msarett, 2016-08-23 14:03:16]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 14:03:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 14:24:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 14:24:34]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-08-23 22:58:01]

Adding function to be called by test code

[mtklein, 2016-08-24 00:30:26]

The CQ bit was checked by mtklein@google.com

[mtklein, 2016-08-24 00:30:26]

lgtm

[commit-bot: I haz the power, 2016-08-24 00:30:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 00:53:09]

Description was changed from

==========
Fix generic color space xform, ColorSpaceXformTest

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275563002
==========

to

==========
Fix generic color space xform, ColorSpaceXformTest

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275563002

Committed:
https://skia.googlesource.com/skia/+/9dc6cf6b8833d36c29a23d2519989b069745fcd5
==========

[commit-bot: I haz the power, 2016-08-24 00:53:10]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9dc6cf6b8833d36c29a23d2519989b069745fcd5