Move toXYZD50() to SkColorSpace_Base

Move toXYZD50() to SkColorSpace_Base

SkColorSpace needs to become more versatile, in order to support
profiles that cannot specified with just a "to XYZ D50" matrix.

This a just first step to clean up the public API.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2381553002

Committed: https://skia.googlesource.com/skia/+/7802c3db24effa6f3186bff7490a2a8dd85d2a70

[msarett, 2016-09-28 15:26:16]

Description was changed from

==========
Move toXYZD50() to SkColorSpace_Base

SkColorSpace needs to become more versatile, in order to support
profiles that cannot specified with just a "to XYZ D50" matrix.

This a just first step to clean up the public API.

BUG=skia:
==========

to

==========
Move toXYZD50() to SkColorSpace_Base

SkColorSpace needs to become more versatile, in order to support
profiles that cannot specified with just a "to XYZ D50" matrix.

This a just first step to clean up the public API.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2381553002
==========

[msarett, 2016-09-28 15:26:23]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 15:26:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msarett, 2016-09-28 15:26:47]

msarett@google.com changed reviewers:
+ brianosman@google.com, raftias@google.com, reed@google.com

[Brian Osman, 2016-09-28 15:30:27]

https://codereview.chromium.org/2381553002/diff/1/src/core/SkColorSpace_Base.h
File src/core/SkColorSpace_Base.h (right):

https://codereview.chromium.org/2381553002/diff/1/src/core/SkColorSpace_Base....
src/core/SkColorSpace_Base.h:218: /**
This comment seems like it belongs with the accessor, not the field?

[msarett, 2016-09-28 15:33:51]

https://codereview.chromium.org/2381553002/diff/1/src/core/SkColorSpace_Base.h
File src/core/SkColorSpace_Base.h (right):

https://codereview.chromium.org/2381553002/diff/1/src/core/SkColorSpace_Base....
src/core/SkColorSpace_Base.h:218: /**
On 2016/09/28 15:30:27, Brian Osman wrote:
> This comment seems like it belongs with the accessor, not the field?

Yeah oops, I think I'll delete this altogether.

[msarett, 2016-09-28 15:33:56]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 15:33:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-09-28 15:41:48]

api lgtm

[commit-bot: I haz the power, 2016-09-28 16:10:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 16:10:58]

Dry run: This issue passed the CQ dry run.

[Brian Osman, 2016-09-28 17:18:48]

lgtm

[msarett, 2016-09-28 17:21:18]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-09-28 17:21:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 17:23:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 17:23:38]

Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[msarett, 2016-09-28 17:27:14]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-09-28 17:27:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 17:28:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 17:28:07]

Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[msarett, 2016-09-28 17:43:28]

The CQ bit was checked by msarett@google.com

[msarett, 2016-09-28 17:43:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
brianosman@google.com, reed@google.com
Link to the patchset: https://codereview.chromium.org/2381553002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-28 17:43:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 18:15:29]

Description was changed from

==========
Move toXYZD50() to SkColorSpace_Base

SkColorSpace needs to become more versatile, in order to support
profiles that cannot specified with just a "to XYZ D50" matrix.

This a just first step to clean up the public API.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2381553002
==========

to

==========
Move toXYZD50() to SkColorSpace_Base

SkColorSpace needs to become more versatile, in order to support
profiles that cannot specified with just a "to XYZ D50" matrix.

This a just first step to clean up the public API.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2381553002

Committed:
https://skia.googlesource.com/skia/+/7802c3db24effa6f3186bff7490a2a8dd85d2a70
==========

[commit-bot: I haz the power, 2016-09-28 18:15:30]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/7802c3db24effa6f3186bff7490a2a8dd85d2a70