Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2255963002: Batched implementation of drawLattice() for GPU (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
bsalomon, djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Batched implementation of drawLattice() for GPU Bechmarks (Nexus 6P): Src=100x100, Dst=250x250, NumRects=9 Android 77.7us Skia (without patch) 57.2us Skia (with patch) 30.9us Src=100x100, Dst=500x500, NumRects=9 Android 77.0us Skia (without patch) 56.9us Skia (with patch) 31.8us Src=100x100, Dst=1000x1000, NumRects=9 Android 180us Skia (without patch) 96.8us Skia (with patch) 70.5us Src=100x100, Dst=250x250, NumRects=15 Android 208us Skia (without patch) 155us Skia (with patch) 38.2us Src=100x100, Dst=500x500, NumRects=15 Android 207us Skia (without patch) 152us Skia (with patch) 38.4us Src=100x100, Dst=1000x1000, NumRects=15 Android 233us Skia (without patch) 156us Skia (with patch) 99.9us BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255963002 Committed: https://skia.googlesource.com/skia/+/93242c4ae50dfcc0d922cdb3ba80bbc7b4bbe93d Committed: https://skia.googlesource.com/skia/+/10e3d9bf59bdec92c05367ae0b71e1ce1ee4a690

Patch Set 1 #

Patch Set 2 : Think this should work #

Patch Set 3 : Clean up #

Patch Set 4 : Improve bench #

Total comments: 7

Patch Set 5 : Response to comments #

Patch Set 6 : Improve bench, move matrix map outside loop #

Patch Set 7 : Rebase #

Patch Set 8 : Speculative reland #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -57 lines) Patch
M bench/DrawLatticeBench.cpp View 1 2 3 4 5 2 chunks +18 lines, -3 lines 0 comments Download
M include/gpu/GrDrawContext.h View 1 2 chunks +9 lines, -19 lines 0 comments Download
M include/private/SkTArray.h View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
M src/core/SkLatticeIter.h View 1 2 3 4 5 1 chunk +15 lines, -2 lines 0 comments Download
M src/core/SkLatticeIter.cpp View 1 2 3 4 5 3 chunks +17 lines, -0 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 2 chunks +11 lines, -9 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 2 3 4 5 6 2 chunks +8 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 5 6 2 chunks +59 lines, -2 lines 0 comments Download
M src/gpu/batches/GrNinePatch.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/batches/GrNinePatch.cpp View 1 2 3 4 5 6 7 6 chunks +30 lines, -21 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 41 (31 generated)
msarett
Improves performance a bit for drawing Android's ninepatches. https://codereview.chromium.org/2255963002/diff/100001/bench/DrawLatticeBench.cpp File bench/DrawLatticeBench.cpp (right): https://codereview.chromium.org/2255963002/diff/100001/bench/DrawLatticeBench.cpp#newcode45 bench/DrawLatticeBench.cpp:45: void ...
4 years, 4 months ago (2016-08-18 15:16:08 UTC) #9
bsalomon
https://codereview.chromium.org/2255963002/diff/100001/bench/DrawLatticeBench.cpp File bench/DrawLatticeBench.cpp (right): https://codereview.chromium.org/2255963002/diff/100001/bench/DrawLatticeBench.cpp#newcode45 bench/DrawLatticeBench.cpp:45: void onDraw(int loops, SkCanvas* canvas) override { On 2016/08/18 ...
4 years, 4 months ago (2016-08-18 15:40:26 UTC) #10
msarett
https://codereview.chromium.org/2255963002/diff/100001/src/gpu/batches/GrNinePatch.cpp File src/gpu/batches/GrNinePatch.cpp (right): https://codereview.chromium.org/2255963002/diff/100001/src/gpu/batches/GrNinePatch.cpp#newcode110 src/gpu/batches/GrNinePatch.cpp:110: patch.fViewMatrix.mapPointsWithStride(positions, vertexStride, kVertsPerRect); On 2016/08/18 15:40:26, bsalomon wrote: > ...
4 years, 4 months ago (2016-08-18 17:49:20 UTC) #11
msarett
I've moved all of the matrix computation out of the loop now. And I've also ...
4 years, 4 months ago (2016-08-18 19:19:26 UTC) #14
bsalomon
lgtm, numbers look nice!
4 years, 4 months ago (2016-08-18 19:26:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255963002/180001
4 years, 4 months ago (2016-08-18 20:10:53 UTC) #27
commit-bot: I haz the power
Committed patchset #7 (id:180001) as https://skia.googlesource.com/skia/+/93242c4ae50dfcc0d922cdb3ba80bbc7b4bbe93d
4 years, 4 months ago (2016-08-18 20:11:52 UTC) #29
msarett
A revert of this CL (patchset #7 id:180001) has been created in https://codereview.chromium.org/2255683004/ by msarett@google.com. ...
4 years, 4 months ago (2016-08-18 21:29:14 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255963002/200001
4 years, 4 months ago (2016-08-18 22:45:09 UTC) #39
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 22:46:07 UTC) #41
Message was sent while issue was closed.
Committed patchset #8 (id:200001) as
https://skia.googlesource.com/skia/+/10e3d9bf59bdec92c05367ae0b71e1ce1ee4a690

Powered by Google App Engine
This is Rietveld 408576698