Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2326043002: Delete some LUTs from SkColorSpaceXform (Closed)

Created:
4 years, 3 months ago by msarett
Modified:
4 years, 3 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Delete some LUTs from SkColorSpaceXform No need to keep these around. In the rare case that these are needed, we can just go ahead and build them. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2326043002 Committed: https://skia.googlesource.com/skia/+/55bcc8e0af3415601b3d62252a0d579fbe87c85a

Patch Set 1 #

Patch Set 2 : Type f for float #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -126 lines) Patch
M src/core/SkColorSpaceXform.cpp View 1 3 chunks +8 lines, -126 lines 0 comments Download
M tests/ColorSpaceXformTest.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (13 generated)
msarett
4 years, 3 months ago (2016-09-09 13:44:06 UTC) #4
mtklein
lgtm
4 years, 3 months ago (2016-09-09 14:14:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326043002/40001
4 years, 3 months ago (2016-09-09 14:47:11 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 14:48:08 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/55bcc8e0af3415601b3d62252a0d579fbe87c85a

Powered by Google App Engine
This is Rietveld 408576698