Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed)

Created:
4 years, 8 months ago by kotenkov
Modified:
4 years, 8 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ASSERT -> DCHECK in core/editing. BUG=596760 Committed: https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d Cr-Commit-Position: refs/heads/master@{#388153}

Patch Set 1 #

Patch Set 2 : Fix compilation. #

Total comments: 13

Patch Set 3 : Split some DCHECKs in two. #

Patch Set 4 : Rebase. #

Total comments: 2

Patch Set 5 : Fix typo. #

Patch Set 6 : Fix typo. #

Patch Set 7 : Rebase. #

Total comments: 85

Patch Set 8 : Rebase. #

Patch Set 9 : Output info for some DCHECKs, add TODOs. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+647 lines, -617 lines) Patch
M third_party/WebKit/Source/core/editing/CaretBase.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 2 3 4 5 6 7 8 10 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStrategy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 1 2 3 4 5 6 7 8 18 chunks +22 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 2 3 4 5 6 7 8 12 chunks +20 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 2 3 21 chunks +23 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EphemeralRange.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EphemeralRange.cpp View 1 2 3 4 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 2 3 4 5 6 7 8 10 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/PendingSelection.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PlainTextRange.h View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PlainTextRange.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Position.h View 1 2 3 4 5 6 7 8 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Position.cpp View 1 2 3 4 5 6 7 7 chunks +15 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PositionIterator.cpp View 13 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/editing/RenderedPosition.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionEditor.cpp View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SurroundingText.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 2 3 4 5 6 8 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 21 chunks +24 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/AppendNodeCommand.cpp View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp View 1 2 3 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 1 2 3 4 5 6 7 8 28 chunks +45 lines, -41 lines 1 comment Download
M third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 2 3 4 5 6 7 8 25 chunks +42 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp View 1 2 3 4 5 6 7 8 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditCommand.cpp View 1 2 3 4 5 6 7 8 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditingState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 2 3 4 5 6 15 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp View 1 2 3 7 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertNodeBeforeCommand.cpp View 1 2 3 4 5 6 7 8 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp View 1 2 3 4 5 6 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp View 1 2 3 4 5 6 7 8 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/MergeIdenticalElementsCommand.cpp View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/RemoveCSSPropertyCommand.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/RemoveNodeCommand.cpp View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/RemoveNodePreservingChildrenCommand.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 1 2 3 4 5 6 7 8 9 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SetNodeAttributeCommand.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SmartReplaceICU.cpp View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommand.cpp View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 1 2 3 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UndoStack.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/WrapContentsInDummySpanCommand.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/BackwardsCharacterIterator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/BackwardsTextBuffer.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/ForwardsTextBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/FullyClippedStateStack.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp View 1 2 3 4 5 6 7 8 14 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp View 1 2 3 4 5 6 7 8 8 chunks +20 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextBufferBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 1 2 3 4 5 6 7 8 15 chunks +18 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp View 1 2 3 4 5 6 7 8 7 chunks +17 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 2 3 13 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp View 1 2 3 4 5 6 7 8 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/Serialization.cpp View 1 2 3 4 5 6 7 8 11 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp View 1 2 3 4 5 6 7 8 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp View 1 2 3 4 5 6 7 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 2 3 6 chunks +18 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp View 1 2 3 16 chunks +38 lines, -30 lines 0 comments Download

Messages

Total messages: 20 (5 generated)
kotenkov
4 years, 8 months ago (2016-04-10 21:14:57 UTC) #2
yosin_UTC9
lgtm w/ nits Please rewrite ASSERT(min <= value && value <= max) to DCHECK_GE(value, min); ...
4 years, 8 months ago (2016-04-11 04:09:11 UTC) #3
yosin_UTC9
4 years, 8 months ago (2016-04-11 04:09:33 UTC) #4
kotenkov
On 2016/04/11 04:09:11, Yosi_UTC9 wrote: > lgtm w/ nits > > Please rewrite > ASSERT(min ...
4 years, 8 months ago (2016-04-11 20:08:57 UTC) #5
yosin_UTC9
https://codereview.chromium.org/1878473002/diff/60001/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp File third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp (right): https://codereview.chromium.org/1878473002/diff/60001/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp#newcode138 third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp:138: DCHECK(currentPosition.computeContainerNode()->treeScope() == treeScope); s/==/!=/ This is the reason of ...
4 years, 8 months ago (2016-04-12 01:45:23 UTC) #6
kotenkov
https://codereview.chromium.org/1878473002/diff/60001/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp File third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp (right): https://codereview.chromium.org/1878473002/diff/60001/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp#newcode138 third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp:138: DCHECK(currentPosition.computeContainerNode()->treeScope() == treeScope); On 2016/04/12 01:45:23, Yosi_UTC9 wrote: > ...
4 years, 8 months ago (2016-04-12 06:05:24 UTC) #7
kotenkov
I have fix another typo and had to rebase once more. PTAL.
4 years, 8 months ago (2016-04-13 14:59:30 UTC) #8
yosin_UTC9
How about utilizing stream facility of |DCHECK|? If so, we can see erroneous value at ...
4 years, 8 months ago (2016-04-14 04:35:04 UTC) #9
kotenkov
Done. I hope I didn't miss anything. https://codereview.chromium.org/1878473002/diff/120001/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp File third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp (right): https://codereview.chromium.org/1878473002/diff/120001/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp#newcode151 third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp:151: DCHECK(length); On ...
4 years, 8 months ago (2016-04-18 15:02:57 UTC) #10
yosin_UTC9
lgtm https://codereview.chromium.org/1878473002/diff/160001/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp File third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp (right): https://codereview.chromium.org/1878473002/diff/160001/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp#newcode939 third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp:939: DCHECK(runStart); (^_^)b
4 years, 8 months ago (2016-04-19 01:38:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878473002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878473002/160001
4 years, 8 months ago (2016-04-19 01:38:38 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/55926)
4 years, 8 months ago (2016-04-19 01:45:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878473002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878473002/160001
4 years, 8 months ago (2016-04-19 06:08:41 UTC) #17
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 8 months ago (2016-04-19 07:09:49 UTC) #18
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 07:11:12 UTC) #20
Message was sent while issue was closed. 
Patchset 9 (id:??) landed as
https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d
Cr-Commit-Position: refs/heads/master@{#388153}

Powered by Google App Engine
This is Rietveld 408576698