third_party/WebKit/Source/core/editing/EditingStrategy.cpp - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingStrategy.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/EditingStrategy.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditingStrategy.cpp b/third_party/WebKit/Source/core/editing/EditingStrategy.cpp

index 742fbb42ded5c405170d72f08023e1be1d62c437..181778c3f3c9f4979dda616202fe8d51ddc8a6e6 100644

--- a/third_party/WebKit/Source/core/editing/EditingStrategy.cpp

+++ b/third_party/WebKit/Source/core/editing/EditingStrategy.cpp

@@ -45,7 +45,7 @@ bool EditingAlgorithm<Traversal>::editingIgnoresContent(const Node* node)

template <typename Traversal>

int EditingAlgorithm<Traversal>::lastOffsetForEditing(const Node* node)

{

- ASSERT(node);

+ DCHECK(node);

if (!node)

return 0;

if (node->offsetInCharacters())