third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/MergeIdenticalElementsCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/RemoveCSSPropertyCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp

index 81b3f3e3677e7e74417a6b58740903949a28ff13..221127ce34ec84f9561ce1679cec9917ac4481f3 100644

--- a/third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp

@@ -33,12 +33,12 @@ namespace blink {

MoveSelectionCommand::MoveSelectionCommand(DocumentFragment* fragment, const Position& position, bool smartInsert, bool smartDelete)

: CompositeEditCommand(*position.document()), m_fragment(fragment), m_position(position), m_smartInsert(smartInsert), m_smartDelete(smartDelete)

{

- ASSERT(m_fragment);

+ DCHECK(m_fragment);

}

void MoveSelectionCommand::doApply(EditingState* editingState)

{

- ASSERT(endingSelection().isNonOrphanedRange());

+ DCHECK(endingSelection().isNonOrphanedRange());

Position pos = m_position;

if (pos.isNull())