third_party/WebKit/Source/core/editing/RenderedPosition.cpp - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/RenderedPosition.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/RenderedPosition.cpp

diff --git a/third_party/WebKit/Source/core/editing/RenderedPosition.cpp b/third_party/WebKit/Source/core/editing/RenderedPosition.cpp

index eb4be7302c1e4dddbec13fbef3863a749d51e82d..951cddccf10ca1f91d4d152e6dc97e40d6b175dc 100644

--- a/third_party/WebKit/Source/core/editing/RenderedPosition.cpp

+++ b/third_party/WebKit/Source/core/editing/RenderedPosition.cpp

@@ -41,7 +41,7 @@ namespace blink {

static inline LayoutObject* layoutObjectFromPosition(const Position& position)

{

- ASSERT(position.isNotNull());

+ DCHECK(position.isNotNull());

Node* layoutObjectNode = nullptr;

switch (position.anchorType()) {

case PositionAnchorType::OffsetInAnchor:

@@ -208,7 +208,7 @@ bool RenderedPosition::atRightBoundaryOfBidiRun(ShouldMatchBidiLevel shouldMatch

Position RenderedPosition::positionAtLeftBoundaryOfBiDiRun() const

{

- ASSERT(atLeftBoundaryOfBidiRun());

+ DCHECK(atLeftBoundaryOfBidiRun());

if (atLeftmostOffsetInBox())

return Position::editingPositionOf(m_layoutObject->node(), m_offset);

@@ -218,7 +218,7 @@ Position RenderedPosition::positionAtLeftBoundaryOfBiDiRun() const

Position RenderedPosition::positionAtRightBoundaryOfBiDiRun() const

{

- ASSERT(atRightBoundaryOfBidiRun());

+ DCHECK(atRightBoundaryOfBidiRun());

if (atRightmostOffsetInBox())

return Position::editingPositionOf(m_layoutObject->node(), m_offset);