third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp

index 0d919d12031bd68dcf93570b986de3eba9f89796..fd29c5ff67f644607385af0437ba49d622b93a87 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp

@@ -39,9 +39,9 @@ InsertIntoTextNodeCommand::InsertIntoTextNodeCommand(Text* node, unsigned offset

, m_offset(offset)

, m_text(text)

{

- ASSERT(m_node);

- ASSERT(m_offset <= m_node->length());

- ASSERT(!m_text.isEmpty());

+ DCHECK(m_node);

+ DCHECK_LE(m_offset, m_node->length());

+ DCHECK(!m_text.isEmpty());

}

void InsertIntoTextNodeCommand::doApply(EditingState*)