third_party/WebKit/Source/core/editing/iterators/ForwardsTextBuffer.cpp - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/ForwardsTextBuffer.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp ('k') | third_party/WebKit/Source/core/editing/iterators/FullyClippedStateStack.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/ForwardsTextBuffer.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/ForwardsTextBuffer.cpp b/third_party/WebKit/Source/core/editing/iterators/ForwardsTextBuffer.cpp

index 9bc426895f169b4e0a6a7235d610bd4ed3a99233..707706cde9bc4bc9b858a7c63e5540576be1661b 100644

--- a/third_party/WebKit/Source/core/editing/iterators/ForwardsTextBuffer.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/ForwardsTextBuffer.cpp

@@ -13,7 +13,7 @@ const UChar* ForwardsTextBuffer::data() const

UChar* ForwardsTextBuffer::calcDestination(size_t length)

{

- ASSERT(size() + length <= capacity());

+ DCHECK_LE(size() + length, capacity());

return bufferBegin() + size();

}