third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/SmartReplaceICU.cpp ('k') | third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp b/third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp

index 8a71022d19455ede47bbce96b8704b94a3005055..8181f84fb399f36087d5bb56dd1ebb1516cbbab9 100644

--- a/third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp

@@ -38,9 +38,9 @@ SplitElementCommand::SplitElementCommand(Element* element, Node* atChild)

, m_element2(element)

, m_atChild(atChild)

{

- ASSERT(m_element2);

- ASSERT(m_atChild);

- ASSERT(m_atChild->parentNode() == m_element2);

+ DCHECK(m_element2);

+ DCHECK(m_atChild);

+ DCHECK_EQ(m_atChild->parentNode(), m_element2);

}

void SplitElementCommand::executeApply()