third_party/WebKit/Source/core/editing/iterators/FullyClippedStateStack.cpp - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/FullyClippedStateStack.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Output info for some DCHECKs, add TODOs. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/iterators/ForwardsTextBuffer.cpp ('k') | third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/FullyClippedStateStack.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/FullyClippedStateStack.cpp b/third_party/WebKit/Source/core/editing/iterators/FullyClippedStateStack.cpp

index 17cc709a96a3bc80b8172d2ed087b68a2502184e..35950274b4c3d962db9ef7f8802b0dd32a978d0a 100644

--- a/third_party/WebKit/Source/core/editing/iterators/FullyClippedStateStack.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/FullyClippedStateStack.cpp

@@ -54,7 +54,7 @@ FullyClippedStateStackAlgorithm<Strategy>::~FullyClippedStateStackAlgorithm()

template<typename Strategy>

void FullyClippedStateStackAlgorithm<Strategy>::pushFullyClippedState(Node* node)

{

- ASSERT(size() == depthCrossingShadowBoundaries<Strategy>(*node));

+ DCHECK_EQ(size(), depthCrossingShadowBoundaries<Strategy>(*node));

// FIXME: m_fullyClippedStack was added in response to <https://bugs.webkit.org/show_bug.cgi?id=26364>

// ("Search can find text that's hidden by overflow:hidden"), but the logic here will not work correctly if

@@ -84,7 +84,7 @@ void FullyClippedStateStackAlgorithm<Strategy>::setUpFullyClippedStack(Node* nod

pushFullyClippedState(ancestry[ancestrySize - i - 1]);

pushFullyClippedState(node);

- ASSERT(size() == 1 + depthCrossingShadowBoundaries<Strategy>(*node));

+ DCHECK_EQ(size(), 1 + depthCrossingShadowBoundaries<Strategy>(*node));

}

template class CORE_TEMPLATE_EXPORT FullyClippedStateStackAlgorithm<EditingStrategy>;